Migrate SCT verbose filter and datarouter filter tests to integration#117
Migrate SCT verbose filter and datarouter filter tests to integration#117RSingh1511 wants to merge 16 commits into
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
e6c1841 to
56e3195
Compare
|
The created documentation from the pull request is available at: docu-html |
56e3195 to
669dd9f
Compare
669dd9f to
f3cf43a
Compare
f3cf43a to
bb37dde
Compare
bb37dde to
40b7b56
Compare
40b7b56 to
6334c84
Compare
6334c84 to
785ed2e
Compare
785ed2e to
1f106fa
Compare
rmaddikery
left a comment
There was a problem hiding this comment.
Some suggestions for re-structure for better navigate and maintain:
score/test/component/filters_app (common code for component tests)
score/test/component/logging_app (common code for component tests)
score/test/component/dlt_generator_app (common code for component tests)
score/test/component/datarouter/test_datarouter_filters.py
score/test/component/mw_log/test_mw_log_filters.py
score/test/component/mw_log/test_mw_log.py
score/test/component/mw_log/test_mw_log_kFile.py
rmaddikery
left a comment
There was a problem hiding this comment.
And a separate workflow that runs these component tests
e5213ee to
7336289
Compare
- Move score/test/integration/ -> score/test/component/ to distinguish from nightly integration tests (reviewer: rmaddikery) - Rename integration_config_files -> integration_test_config_files in score/datarouter/BUILD (reviewer: rmaddikery) - Remove custom dlt_parser.py; refactor all tests to use DltLogRecord from score_itf (score.itf.plugins.dlt.dlt_window) via download_dlt() helper in logging_plugin.py (reviewer: rmaddikery)
| filegroup( | ||
| name = "integration_test_config_files", | ||
| srcs = [ | ||
| "etc/log-channels.json", |
There was a problem hiding this comment.
| "etc/log-channels.json", |
this file is missing. so why include?
| srcs = [ | ||
| "etc/log-channels.json", | ||
| "etc/logging.json", | ||
| "etc/raw-channels.json", |
There was a problem hiding this comment.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #