Describe the bug
The response is not closed after pinging the session:
|
client.newCall(postRequest).execute(); |
Expected behavior
try (var response = client.newCall(request).execute()) {
// Maybe handle !response.isSuccessful()?
} catch (IOException e) {
LOGGER.info("[{}] Could not send message to extension: {}", session.getSpec().getName(), e);
}
Bonus, one OkHttpClient is created per app lifecycle, not one per request:
|
OkHttpClient client = new OkHttpClient().newBuilder().build(); |
Maybe log the !response.isSuccessful() case?
Cluster provider
No response
Version
No response
Additional information
Update:
Same issue in
|
client.newCall(postRequest).execute(); |
Describe the bug
The response is not closed after pinging the session:
theia-cloud/java/operator/org.eclipse.theia.cloud.operator/src/main/java/org/eclipse/theia/cloud/operator/messaging/MonitorMessagingServiceImpl.java
Line 86 in 55813e2
Expected behavior
Bonus, one
OkHttpClientis created per app lifecycle, not one per request:theia-cloud/java/operator/org.eclipse.theia.cloud.operator/src/main/java/org/eclipse/theia/cloud/operator/messaging/MonitorMessagingServiceImpl.java
Line 73 in 55813e2
Maybe log the
!response.isSuccessful()case?Cluster provider
No response
Version
No response
Additional information
Update:
Same issue in
theia-cloud/java/operator/org.eclipse.theia.cloud.operator/src/main/java/org/eclipse/theia/cloud/operator/plugins/MonitorActivityTracker.java
Line 155 in 83c8f60