Skip to content

refactor: migrate usages of the Provider class#5104

Open
yeikel wants to merge 1 commit into
eclipse-vertx:masterfrom
yeikel:migrate/provider-class-usage
Open

refactor: migrate usages of the Provider class#5104
yeikel wants to merge 1 commit into
eclipse-vertx:masterfrom
yeikel:migrate/provider-class-usage

Conversation

@yeikel

@yeikel yeikel commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

The constructor we are using was deprecated in Java 9

 /**
     * Constructs a provider with the specified name, version number,
     * and information. Calling this constructor is equivalent to call the
     * {@link #Provider(String, String, String)} with {@code name}
     * name, {@code Double.toString(version)}, and {@code info}.
     *
     * @param name the provider name.
     *
     * @param version the provider version number.
     *
     * @param info a description of the provider and its services.
     *
     * @deprecated use {@link #Provider(String, String, String)} instead.
     */

The constructor we are using was deprecated in Java 9
@yeikel yeikel force-pushed the migrate/provider-class-usage branch from b97d312 to f7a523b Compare February 7, 2024 02:29
@zll600

zll600 commented Apr 21, 2024

Copy link
Copy Markdown

But jdk1.8 only has original version of api. ref: https://docs.oracle.com/javase/8/docs/api/java/security/Provider.html
And vertx is support JDK 1.8 or higher. ref: https://vertx.io/get-started/
Is it safe to do this?

@yeikel

yeikel commented Apr 22, 2024

Copy link
Copy Markdown
Contributor Author

But jdk1.8 only has original version of api. ref: https://docs.oracle.com/javase/8/docs/api/java/security/Provider.html
And vertx is support JDK 1.8 or higher. ref: https://vertx.io/get-started/
Is it safe to do this?

Vert.x 5 will target Java 11

@vietj vietj added this to the 5.0.0 milestone Apr 22, 2024
@vietj

vietj commented Apr 22, 2024

Copy link
Copy Markdown
Member

thanks , there are a few occurrences of this in other classes:

  • KeyManagerFactoryWrapper
  • TrustAllOptions
  • VertxTrustManagerFactory

@vietj vietj modified the milestones: 5.0.0, 5.1.0 May 14, 2025
@vietj vietj modified the milestones: 5.1.0, 5.1.1, 5.1.2 May 31, 2026
@vietj vietj modified the milestones: 5.1.2, 5.1.3 Jun 8, 2026
@vietj vietj modified the milestones: 5.1.3, 5.1.4 Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants