Skip to content

Feat/atmos sea ice land indicators#50

Merged
chpolste merged 14 commits intoecmwf:wp3from
Predictia:feat/atmos-seaIce-land-indicators
Apr 8, 2026
Merged

Feat/atmos sea ice land indicators#50
chpolste merged 14 commits intoecmwf:wp3from
Predictia:feat/atmos-seaIce-land-indicators

Conversation

@AntonioCC808
Copy link
Copy Markdown
Contributor

Description

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@chpolste chpolste self-requested a review April 7, 2026 14:01
Copy link
Copy Markdown
Member

@chpolste chpolste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just the cell output and link in the docs to fix, the rest looks good! My preference would also be to go with sea_ice/sea_ice.py or ocean/sea_ice.py for that submodule.

With the amount of indicators growing, it would be good to have a discussion on the organisation and naming of submodules in ek-climate soon. The overlap with hydro brings up the question if we want to spread some functionality to the more specialised packages. The seaIce naming brings up the question if we want to mirror the xclim structure exactly (probably not). We're also 3 levels deep with submodules now (e.g., .indicators.atmos.precipitation) while the other earthkits tend to keep things quite flat. That's for another PR though...

@chpolste chpolste merged commit f221f54 into ecmwf:wp3 Apr 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants