Skip to content

chore: remove dead _cachedChainId immutable in EIP712 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
re1ro wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove dead _cachedChainId immutable in EIP712 #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/lib/EIP712.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ abstract contract EIP712 is IERC5267 {
/// @dev Value of 1 enables signatures to work across all chains
uint256 private constant CROSS_CHAIN_ID = 1;

// Cache the domain separator as an immutable value, but also store the chain id that it corresponds to, in order to
// invalidate the cached domain separator if the chain id changes.
// Cache the domain separator as an immutable value, keyed only on `address(this)` so it can be invalidated if the
// contract address changes (e.g. via proxy). The chain id is intentionally NOT part of the cache key: the domain
// deliberately uses a constant chain id (CROSS_CHAIN_ID = 1) for cross-chain signature compatibility.
Comment on lines +25 to +27
bytes32 private immutable _cachedDomainSeparator;
uint256 private immutable _cachedChainId;
address private immutable _cachedThis;

bytes32 private immutable _hashedName;
Expand Down Expand Up @@ -54,7 +54,6 @@ abstract contract EIP712 is IERC5267 {
_hashedName = keccak256(bytes(name));
_hashedVersion = keccak256(bytes(version));

_cachedChainId = CROSS_CHAIN_ID;
_cachedDomainSeparator = _buildDomainSeparator();
_cachedThis = address(this);
}
Expand Down
Loading