Resolve plan ambiguities, add review tooling and review findings - #134
Closed
kingryad wants to merge 1 commit into
Closed
Resolve plan ambiguities, add review tooling and review findings#134kingryad wants to merge 1 commit into
kingryad wants to merge 1 commit into
Conversation
PLAN.md: pin down the contracts where the Frontend and Backend agents would each have invented an incompatible answer — SSE frame shape, error envelope, chat actions schema, priced-set union rule, trade execution rules — and record the reasoning in a resolution log. Four open questions for the project owner remain (Q1 blocks frontend work). SKILL.md: rename the skill frontmatter cerebras-inference -> cerebras so PLAN section 9's reference actually resolves. Add the reviewer subagent and doc-review command that produced the PLAN revision, so the workflow is reproducible from a fresh clone, plus REVIEW.md recording the current review findings. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns the parts of
PLAN.mdwhere the Frontend and Backend agents would each have invented an incompatible answer into explicit contracts, and adds the review tooling that produced the revision.planning/PLAN.md— pins down the SSE frame shape (documented verbatim from the shippedstream.py), a single error envelope with stable codes, the chatactionsschema, the priced-set union rule (watchlist ∪ non-zero positions), and trade execution rules. A resolution log records what was decided and why, so the reasoning is recoverable without re-litigating it..claude/skills/cerebras/SKILL.md— renames the frontmattercerebras-inference→cerebras. Before this, §9's reference didn't resolve to the skill..claude/agents/reviewer.md,.claude/commands/doc-review.md— previously untracked, so the workflow that produced this revision wasn't reproducible from a fresh clone.planning/REVIEW.md— current review findings.Open questions
Four questions for the project owner are recorded at the end of
PLAN.md. Q1 blocks frontend work: addingprevious_closemeans editing the market-data subsystem that's marked complete/tested/reviewed. The alternative is dropping the daily change % column.Findings worth acting on before the next build phase
From
REVIEW.md, highest severity first:backend/app/market/stream.py:17creates a module-levelAPIRouter, socreate_stream_router()isn't the globals-free factory its docstring claims — two calls register two routes on the same object and the second app silently streams the first app'sPriceCache.previous_closedoesn't exist yet (models.py:13-16), and §10 tells the frontend to compute daily change % from it..gitignore:17islib/with no leading slash, which silently ignoresfrontend/lib/andfrontend/src/lib/— the default shadcn/Tailwind location for the exact stack §10 specifies.README.mdcontradicts the revised plan on four points (lazy init, named volume, required API key, deletedscripts/).Note: the test suite was not run as part of this review —
uvwasn't available in the review environment. Findings are from reading the code,git diff, andgit check-ignore.🤖 Generated with Claude Code