Repository navigation
chore(deps): bump rust-toolchain from 1.98.1 to 1.99.0 in the patch-minor group - #176
Conversation
Bumps the patch-minor group with 1 update: [rust-toolchain](https://github.com/rust-lang/rust). Updates `rust-toolchain` from 1.98.1 to 1.99.0 - [Release notes](https://github.com/rust-lang/rust/releases) - [Changelog](https://github.com/rust-lang/rust/blob/main/RELEASES.md) - [Commits](rust-lang/rust@1.98.1...1.99.0) --- updated-dependencies: - dependency-name: rust-toolchain dependency-version: 1.99.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patch-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — the single-commit Dependabot bump of the pinned Rust toolchain.
- Toolchain bump —
rust-toolchain.tomlmoveschannelfrom1.98.1to1.99.0;profileandcomponents(clippy,rustfmt) are unchanged.
The version is not pinned anywhere else (Cargo.toml rust-version = "1.93" is the MSRV and CI reads rust-toolchain.toml via rustup show active-toolchain). One caveat: 1.99 adds new rustc/clippy lints, so the -D warnings clippy job is the thing to watch. The Windows-only code can't be built in my Linux review environment, so I couldn't check this myself.
claude-sonnet-5-5 | 𝕏
assert_is_empty now covers negated assert!(!x.is_empty()) without a message, and float_cmp no longer fires on the memory tests' exact assert_eq!, which left their #[expect] attributes unfulfilled. Signed-off-by: edbfi <326875205+edbfi@users.noreply.github.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — the follow-up commit 474187e on top of the Dependabot toolchain bump.
- Clippy
assert_is_emptyfixes —assert!(!x.is_empty())becomesassert_ne!(x, "")in thesrc/config/models.rsandsrc/utils/icon_extractor.rstests; theStringvs&strcomparison compiles and behaves identically. - Removed stale
#[expect(clippy::float_cmp)]—tests/memory_usage_test.rsdrops the two attribute blocks around the exactassert_eq!float checks, since per the commit message 1.99 no longer fires the lint there (leaving them would be an unfulfilled expectation under-D warnings). No otherfloat_cmpallow or expect remains in the repo.
The changes are test-only, scoped to the new lints, and consistent with the pedantic clippy setup in Cargo.toml. I couldn't run clippy here (Windows-only code, Linux review environment), so CI is the confirmation.
claude-sonnet-5-5 | 𝕏

Bumps the patch-minor group with 1 update: rust-toolchain.
Updates
rust-toolchainfrom 1.98.1 to 1.99.0Release notes
Sourced from rust-toolchain's releases.
... (truncated)
Changelog
Sourced from rust-toolchain's changelog.
... (truncated)
Commits
b940084Auto merge of #163440 - Mark-Simulacrum:stable-next, r=Mark-Simulacrum8fa690e1.99.0 release notes19d7dab1.99.0 releasedfb0accAuto merge of #163264 - flip1995:clippy-beta-backport, r=Mark-Simulacrumdcc47f7fix:const_trait_implrelated infinite loop in `needless_borrows_for_generi...3c884f7Don't suggestBox::leakinnonnull_unchecked_on_box_ptr(#17752)e5a9d6aFix--explainlint lookup being case-mismatched (#17632)aa05936Auto merge of #162987 - cuviper:beta-next, r=cuviper9e8e33cbuild: Fix thumb_1 cfg to include all "thumb but not thumbv2" targets.bc562d5c-b: Addaeabi_u(read|write)(4|8)intrinsics.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions