Skip to content

chore(deps): bump rust-toolchain from 1.98.1 to 1.99.0 in the patch-minor group - #176

Merged
edbfi merged 2 commits into
mainfrom
dependabot/rust_toolchain/patch-minor-9fc2d81f75
Oct 12, 2026
Merged

edbfi merged 2 commits into
mainfrom
dependabot/rust_toolchain/patch-minor-9fc2d81f75

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 9, 2026

Copy link
Copy Markdown
Contributor

Bumps the patch-minor group with 1 update: rust-toolchain.

Updates rust-toolchain from 1.98.1 to 1.99.0

Release notes

Sourced from rust-toolchain's releases.

Rust 1.99.0

Language

Compiler

Platform Support

Refer to Rust's platform support page for more information on Rust's tiered platform support.

Libraries

... (truncated)

Changelog

Sourced from rust-toolchain's changelog.

Version 1.99.0 (2026-10-01)

Language

Compiler

Platform Support

Refer to Rust's platform support page for more information on Rust's tiered platform support.

Libraries

... (truncated)

Commits
  • b940084 Auto merge of #163440 - Mark-Simulacrum:stable-next, r=Mark-Simulacrum
  • 8fa690e 1.99.0 release notes
  • 19d7dab 1.99.0 release
  • dfb0acc Auto merge of #163264 - flip1995:clippy-beta-backport, r=Mark-Simulacrum
  • dcc47f7 fix: const_trait_impl related infinite loop in `needless_borrows_for_generi...
  • 3c884f7 Don't suggest Box::leak in nonnull_unchecked_on_box_ptr (#17752)
  • e5a9d6a Fix --explain lint lookup being case-mismatched (#17632)
  • aa05936 Auto merge of #162987 - cuviper:beta-next, r=cuviper
  • 9e8e33c build: Fix thumb_1 cfg to include all "thumb but not thumbv2" targets.
  • bc562d5 c-b: Add aeabi_u(read|write)(4|8) intrinsics.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the patch-minor group with 1 update: [rust-toolchain](https://github.com/rust-lang/rust).


Updates `rust-toolchain` from 1.98.1 to 1.99.0
- [Release notes](https://github.com/rust-lang/rust/releases)
- [Changelog](https://github.com/rust-lang/rust/blob/main/RELEASES.md)
- [Commits](rust-lang/rust@1.98.1...1.99.0)

---
updated-dependencies:
- dependency-name: rust-toolchain
  dependency-version: 1.99.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: patch-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust_toolchain_package_manager Pull requests that update rust_toolchain_package_manager code labels Oct 9, 2026
@edbfi
edbfi enabled auto-merge (squash) October 9, 2026 01:34

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — the single-commit Dependabot bump of the pinned Rust toolchain.

  • Toolchain bump — rust-toolchain.toml moves channel from 1.98.1 to 1.99.0; profile and components (clippy, rustfmt) are unchanged.

The version is not pinned anywhere else (Cargo.toml rust-version = "1.93" is the MSRV and CI reads rust-toolchain.toml via rustup show active-toolchain). One caveat: 1.99 adds new rustc/clippy lints, so the -D warnings clippy job is the thing to watch. The Windows-only code can't be built in my Linux review environment, so I couldn't check this myself.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

assert_is_empty now covers negated assert!(!x.is_empty()) without a message,
and float_cmp no longer fires on the memory tests' exact assert_eq!, which
left their #[expect] attributes unfulfilled.

Signed-off-by: edbfi <326875205+edbfi@users.noreply.github.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — the follow-up commit 474187e on top of the Dependabot toolchain bump.

  • Clippy assert_is_empty fixes — assert!(!x.is_empty()) becomes assert_ne!(x, "") in the src/config/models.rs and src/utils/icon_extractor.rs tests; the String vs &str comparison compiles and behaves identically.
  • Removed stale #[expect(clippy::float_cmp)] — tests/memory_usage_test.rs drops the two attribute blocks around the exact assert_eq! float checks, since per the commit message 1.99 no longer fires the lint there (leaving them would be an unfulfilled expectation under -D warnings). No other float_cmp allow or expect remains in the repo.

The changes are test-only, scoped to the new lints, and consistent with the pedantic clippy setup in Cargo.toml. I couldn't run clippy here (Windows-only code, Linux review environment), so CI is the confirmation.

Pullfrog  | Fix it ➔ | View workflow run | Using claude-sonnet-5-5 | 𝕏

@edbfi
edbfi merged commit 78bdec6 into main Oct 12, 2026
8 checks passed
@edbfi
edbfi deleted the dependabot/rust_toolchain/patch-minor-9fc2d81f75 branch October 12, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust_toolchain_package_manager Pull requests that update rust_toolchain_package_manager code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant