Repository navigation
test(updater-probe): remove the probe casks after the per-cask updater test - #52
Merged
Merged
Conversation
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes: the single commit on test/remove-updater-probes, reviewed against main.
- Probe casks removed:
Casks/test/updater-probe.rbandCasks/test/updater-probe-b.rbare deleted. - Probe pipelines removed:
pipelines/updater-probe{,-b}/{config.env,resolve.sh}are deleted, sodiscover.shno longer globs them. - Registries trimmed: both
APPSentries inscripts/inspect-macos.pyand both tokens intest_discovery_separates_kindsare dropped, and the two sets still match.
A tree-wide grep for updater-probe and UpdaterProbe is now empty. Nothing else references Casks/test: the remaining uses are temp trees built inside tests/test_updater.py and scripts/tests/test_pipeline.py. With fewer casks the DeadlineTests arithmetic against update-casks.yml only gets looser. The out-of-tree cleanup of the -latest releases and playground tags is described in the PR body in a safe order.
claude-sonnet-5-5 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
Removes everything #51 added: both probe casks, their pipelines, the
inspect-macos.pyentries and the test entries.git diff 2e23e76(#50's merge) is empty after this PR.Evidence: the production test of #49/#50
publish (updater-probe)andpublish (updater-probe-b)ran in parallel (20:48:31–40). Thenpush (updater-probe-b)(20:49:40–54) andpush (updater-probe)(20:49:56–50:03) ran one after the other:075ab3c → cb19908 → 0b4bb0e, both fast-forwards from the deploy key, both rule suitesbypass, and push CI passed on both. The hosted digests equal the built DMGs.planran.UpdaterProbeB-0.0.3.dmgput onupdater-probe-b-latestfirstpublish (updater-probe-b)failed with "Hosted UpdaterProbeB-0.0.3.dmg differs from upstream".publish (updater-probe)succeeded,publishedlisted only it, and it went through verify and push (0b4bb0e → c14cf2a,bypass). probe-b got no verify or push jobs.With eight casks,
update-casks.ymlneeded no timeout change.After merge
Delete
updater-probe-latestandupdater-probe-b-latesthere, then the fourupdater-probe{,-b}-v0.0.{2,3}releases and tags in edbfi/edbfi-ci-playground. Doing it in that order keeps a scheduled run from hitting a missing release.Owner actions
None.