This repository was archived by the owner on Feb 24, 2024. It is now read-only.
change(i18n): use JSON dictionary files for better compatibility with tooling - #289
Draft
eddieantonio wants to merge 7 commits into
Draft
eddieantonio wants to merge 7 commits into
eddieantonio wants to merge 7 commits into
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eddieantonio/predictive-text-studio/5xRAXPb4ZQ4xGTU4zH6bgqLdLJqL |
eddieantonio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a perfect world, I'd want the dictionary files to be in TypeScript, tooling like i18n-ally is way too cool to pass up! It only works with JSON and YAML however :/
So I converted the translations to JSON . I may tinker around with the commits here to get the attribution right/make it work right. I might even start again, but based off the
productionbranch rather than thelocales/spanishbranch.