feat: keeper runbook, storage report, API pagination, and simulator OpenAPI schema#582
Merged
edehvictor merged 1 commit intoMay 27, 2026
Merged
Conversation
…OpenAPI (edehvictor#546, edehvictor#550, edehvictor#556, edehvictor#560) Closes edehvictor#546 Closes edehvictor#550 Closes edehvictor#556 Closes edehvictor#560
|
@ijeoma270 is attempting to deploy a commit to the Edeh Victor's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@ijeoma270 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #546
Closes #550
Closes #556
Closes #560
What changed
Add Keeper Bot Runbook Documentation #546 — Keeper Bot Runbook (
backend/keepers/README.md): Full operational runbook covering keeper responsibilities (liquidation queue, compound queue), all environment variables with types and defaults, safe local test commands, monitoring log-field reference, restart instructions, and a troubleshooting section for Redis, signer/keypair, queue stalls, repeated job failures, and VaultMonitor scan issues.Add Soroban Contract Storage Usage Report #550 — Storage Usage Report (
docs/contracts/storage-report.md): Per-contract audit of everyDataKey, storage class (instance/persistent/temporary), intended lifetime, TTL extension requirements, and cleanup responsibilities foryield_vault,stablecoin_manager,ve_tokenomics, andoptions. Includes a general TTL policy table and a cleanup summary.Add API Pagination Contract for Large Lists #556 — API Pagination Contract (
server/src/types/pagination.ts,server/src/routes/incidents.ts,server/src/services/incidentService.ts,server/src/__tests__/incidentsPagination.test.ts): Defines a shared cursor-basedPaginatedResponse<T>type withnextCursor,hasMore, andlimitfields. Applied toGET /api/incidents(now accepts?cursor=&limit=and returns the paginated shape). AddedgetIncidentsPaginatedtoIncidentService. Includes 7 passing tests covering first page, second page, empty page, custom limit, limit clamping, invalid limit fallback, and response shape validation.Add Deposit Simulation API OpenAPI Schema #560 — Deposit Simulation OpenAPI Schema (
server/openapi.yaml): DocumentsPOST /api/simulator/depositwith full request schema (strategyId,token,amount), response schema (isSimulationOnly,allocations,expectedShares,fees,postDepositExposure,warnings), named component schemas (DepositSimulationRequest,DepositSimulationResponse,SimulationAllocation,SimulationFee,SimulationError), error response examples for 400 and 500, and aSimulatortag. YAML formatting validated.How to test
backend/keepers/README.md— all env var names matchbackend/keepers/src/config/index.ts.docs/contracts/storage-report.md—DataKeyvariants verified against source files.cd server && npm test -- --testPathPatterns=incidentsPagination— all 7 tests pass.Simulatorsection inserver/openapi.yaml.