Skip to content

fix: resolve issues #428, #453, #455, #457#585

Merged
edehvictor merged 1 commit into
edehvictor:mainfrom
Nanle-code:fix/issues-428-453-455-457
May 28, 2026
Merged

fix: resolve issues #428, #453, #455, #457#585
edehvictor merged 1 commit into
edehvictor:mainfrom
Nanle-code:fix/issues-428-453-455-457

Conversation

@Nanle-code
Copy link
Copy Markdown
Contributor

#428 - Contributor issue claim and progress tracker

  • Add status: claimed/in-progress/needs-update/available labels to .github/labels.yml
  • Add .github/ISSUE_TEMPLATE/claim_issue.yml for structured claim comments
  • Add .github/PROGRESS_UPDATE.md template for 7-day progress updates
  • Document claim lifecycle in CONTRIBUTING.md with label table

#453 - Mobile navigation drawer for dashboard routes

  • Add hamburger Menu/X toggle button (hidden on md+) to nav bar
  • Add slide-in mobile drawer with all routes, wallet-gated sections, and quick actions
  • Drawer closes on route change via useLocation + useEffect
  • Hide desktop nav-links on small screens (hidden md:flex)
  • Add .drawer-link CSS utility to client/src/index.css

#455 - Backend health endpoint dependency breakdown

  • Add /health/dependencies route to server/src/routes/health.ts
  • Returns per-dependency status (database, horizon, indexer, cache) with latency hints
  • Returns 503 when any dependency is down, 200 for warning/up
  • Never exposes credentials or private data
  • Add full test suite in server/src/tests/health.dependencies.test.ts
  • Install @types/jest, @types/node, @types/supertest, supertest dev deps

#457 - Contract error code reference

  • Add contracts/ERROR_CODES.md with per-contract error tables
  • Covers VaultError, StableSwapError, IsolatedLendingError, LiquidStaking Error, OptimisticGovernance Error, SettlementError, BridgeRelayerError, ZapError, StealthError
  • Each entry includes code, name, meaning, and operator remediation
  • Documents panic paths for untyped failures
  • No contract behavior changed

Closes #428
Closes #453
Closes #455
Closes #457

Description

Fixes # (issue number)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Verification Commands

  • npm run lint / npm run test (Frontend/Backend)
  • cargo fmt / cargo clippy / cargo test (Smart Contracts)

Contract Security (if contracts/ changed)

  • Storage schema changes documented or migration provided
  • All entry points have authorization checks
  • Arithmetic uses checked operations
  • New entry points have unit tests including unauthorized callers
  • No new admin roles without governance proposal

Screenshots (if applicable)

Add screenshots to help explain the changes.

UI Snapshot Checklist

  • Screenshots provided for Desktop (1024px+)
  • Screenshots provided for Mobile (375px)
  • No visual changes

…dehvictor#457

edehvictor#428 - Contributor issue claim and progress tracker
- Add status: claimed/in-progress/needs-update/available labels to .github/labels.yml
- Add .github/ISSUE_TEMPLATE/claim_issue.yml for structured claim comments
- Add .github/PROGRESS_UPDATE.md template for 7-day progress updates
- Document claim lifecycle in CONTRIBUTING.md with label table

edehvictor#453 - Mobile navigation drawer for dashboard routes
- Add hamburger Menu/X toggle button (hidden on md+) to nav bar
- Add slide-in mobile drawer with all routes, wallet-gated sections, and quick actions
- Drawer closes on route change via useLocation + useEffect
- Hide desktop nav-links on small screens (hidden md:flex)
- Add .drawer-link CSS utility to client/src/index.css

edehvictor#455 - Backend health endpoint dependency breakdown
- Add /health/dependencies route to server/src/routes/health.ts
- Returns per-dependency status (database, horizon, indexer, cache) with latency hints
- Returns 503 when any dependency is down, 200 for warning/up
- Never exposes credentials or private data
- Add full test suite in server/src/tests/health.dependencies.test.ts
- Install @types/jest, @types/node, @types/supertest, supertest dev deps

edehvictor#457 - Contract error code reference
- Add contracts/ERROR_CODES.md with per-contract error tables
- Covers VaultError, StableSwapError, IsolatedLendingError, LiquidStaking Error,
  OptimisticGovernance Error, SettlementError, BridgeRelayerError, ZapError, StealthError
- Each entry includes code, name, meaning, and operator remediation
- Documents panic paths for untyped failures
- No contract behavior changed

Closes edehvictor#428, Closes edehvictor#453, Closes edehvictor#455, Closes edehvictor#457
@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

@Nanle-code is attempting to deploy a commit to the Edeh Victor's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 28, 2026

@Nanle-code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@edehvictor edehvictor merged commit 9eeb72b into edehvictor:main May 28, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants