apply sensible default to geom_col orientation#32
Open
leungi wants to merge 2 commits intoedgararuiz-zz:masterfrom
Open
apply sensible default to geom_col orientation#32leungi wants to merge 2 commits intoedgararuiz-zz:masterfrom
leungi wants to merge 2 commits intoedgararuiz-zz:masterfrom
Conversation
leungi
commented
Jun 1, 2020
leungi
commented
- this is to address dbplot_histogram resulting in empty plots + proper histograms #31
- setting orientation args of geom_col() to x, plot will show vertical bars, commonly used for histograms
- setting `orientation` args of `geom_col()` to `x`, plot will show vertical bars, commonly used for histograms
apply sensible default to geom_col orientation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.