✅ test: Add missing mock for subscribe_port_speed_change_event in Sfp…#26
Merged
Conversation
…StateUpdateTask test The test_SfpStateUpdateTask_task_run_stop test lacks a mock for subscribe_port_speed_change_event, which can cause test failures when the function attempts to subscribe to actual port speed change events. This aligns with the existing mock for subscribe_port_config_change.
gord1306
requested review from
CharlieChenEC,
PJHsieh,
chiourung,
scjuang,
vincentchiang-ec and
yehjunying
and removed request for
yehjunying
scjuang
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…StateUpdateTask test
The test_SfpStateUpdateTask_task_run_stop test lacks a mock for subscribe_port_speed_change_event, which can cause test failures when the function attempts to subscribe to actual port speed change events. This aligns with the existing mock for subscribe_port_config_change.
Description
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)