QoS template files were not being applied on the Xsight ES9618xx device.#108
Merged
yehjunying merged 1 commit intoAug 4, 2025
Conversation
shihhsien-wang
force-pushed
the
not-load-qos-on-community-brcm-sai
branch
3 times, most recently
from
31cf7a4 to
1633111
Compare
What I did: The original implementation applied QoS template files only when running with ecSAI. The condition was updated to apply the QoS template files by default, except when running with the community Broadcom SAI. As a result, the Xsight ES9618xx device is now able to load the QoS templates as well. Why I did it: The lack of QoS template files on the Xsight ES9618xx caused failures in the pfc_config and ecn_config_update test cases.
shihhsien-wang
force-pushed
the
not-load-qos-on-community-brcm-sai
branch
from
1633111 to
9b1ef4e
Compare
shihhsien-wang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
The original implementation applied QoS template files only when running
with ecSAI. The condition was updated to apply the QoS template files by
default, except when running with the community Broadcom SAI. As a
result, the Xsight ES9618xx device is now able to load the QoS templates
as well.
Why I did it:
The lack of QoS template files on the Xsight ES9618xx caused failures in
the pfc_config and ecn_config_update test cases.