Refactored StartLastGuard method.#427
Conversation
|
This doesn't build. Working on setting up local test server. |
|
This builds. Didn't seem to break anything when loaded onto local test server. |
|
Hey, a few things to address here that are across the entire PR so just a general message:
And heads up, we already have an internal cleanup in progress that covers a lot of what this does. Probably worth syncing up before putting more work into rewrites like this so you're not doubling up on effort. |
ShookEagle
left a comment
There was a problem hiding this comment.
Force pushed without merging in changes, PR targets main instead of dev, and formatting doesn't follow Jailbreak.sln.DotSettings.
5c32086 to
9e01ed4
Compare
|
Okay I think this is g2g now. I rebased with dev and downloaded rider for formatting. Let me know if any further changes are needed. |
As mentioned in the commit message, I refactored the StartLastGuard method into several more concise methods. This might also fix an issue that prevents lg beacon from being applied too. I have not tested this code.