Skip to content

Refactored StartLastGuard method.#427

Open
Koofis1 wants to merge 1 commit into
edgegamers:devfrom
Koofis1:main
Open

Refactored StartLastGuard method.#427
Koofis1 wants to merge 1 commit into
edgegamers:devfrom
Koofis1:main

Conversation

@Koofis1

@Koofis1 Koofis1 commented Mar 24, 2026

Copy link
Copy Markdown

As mentioned in the commit message, I refactored the StartLastGuard method into several more concise methods. This might also fix an issue that prevents lg beacon from being applied too. I have not tested this code.

@Koofis1

Koofis1 commented Mar 24, 2026

Copy link
Copy Markdown
Author

This doesn't build. Working on setting up local test server.

@Koofis1

Koofis1 commented Mar 25, 2026

Copy link
Copy Markdown
Author

This builds. Didn't seem to break anything when loaded onto local test server.

@ShookEagle ShookEagle added status::5 Review Review - Testing complete, merge request is opened and assigned to member of leadership or Tech type::2 Update Update - Changes to currently existing features priority::4 Low Low - We will not prioritize this task. labels Mar 29, 2026
@ShookEagle
ShookEagle self-requested a review March 29, 2026 15:57
@ShookEagle

Copy link
Copy Markdown
Collaborator

Hey, a few things to address here that are across the entire PR so just a general message:

  • Biggest issue, you force pushed without merging in the latest changes first. That can clobber current functionality and make the history a nightmare. Please rebase your branch against dev before pushing again.

  • Also, this is targeting main directly. PRs shouldn't go straight to main; run it through the dev branch. This needs to be

  • Formatting doesn't match our style guide either, so that'll need to be fixed. Format using the included Jailbreak.sln.DotSettings.

And heads up, we already have an internal cleanup in progress that covers a lot of what this does. Probably worth syncing up before putting more work into rewrites like this so you're not doubling up on effort.

@ShookEagle ShookEagle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force pushed without merging in changes, PR targets main instead of dev, and formatting doesn't follow Jailbreak.sln.DotSettings.

@Koofis1
Koofis1 force-pushed the main branch 2 times, most recently from 5c32086 to 9e01ed4 Compare April 1, 2026 03:26
@Koofis1
Koofis1 marked this pull request as draft April 1, 2026 04:23
@Koofis1
Koofis1 changed the base branch from main to dev April 1, 2026 04:25
@Koofis1 Koofis1 closed this Apr 1, 2026
@Koofis1 Koofis1 reopened this Apr 1, 2026
@Koofis1
Koofis1 marked this pull request as ready for review April 1, 2026 06:19
@Koofis1

Koofis1 commented Apr 1, 2026

Copy link
Copy Markdown
Author

Okay I think this is g2g now. I rebased with dev and downloaded rider for formatting. Let me know if any further changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority::4 Low Low - We will not prioritize this task. status::5 Review Review - Testing complete, merge request is opened and assigned to member of leadership or Tech type::2 Update Update - Changes to currently existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants