Repository navigation
feat(build): add negative build flags to compile squix without a set of database drivers - #91
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Moderate issues remain in CGO/negative-tag reporting, local full builds, and error propagation.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Adds build-time database-driver variants and runtime reporting of compiled driver support.
Changes:
- Adds per-driver negative build tags and conditional registration.
- Adds full, lite, and minimal build targets across local, Nix, and release workflows.
- Adds
squix --driversand documents driver availability.
| File | Reviewed change |
|---|---|
README.md |
Links to build variant documentation. |
Makefile |
Adds lite and minimal targets. |
internal/db/sqlserver_connection.go |
Adds conditional SQL Server driver compilation. |
internal/db/sqlite_connection.go |
Adds conditional SQLite driver compilation. |
internal/db/snowflake_connection.go |
Adds conditional Snowflake driver compilation. |
internal/db/postgres_connection.go |
Adds conditional PostgreSQL driver compilation. |
internal/db/oracle_connection.go |
Adds conditional Oracle driver compilation. |
internal/db/mysql_connection.go |
Adds conditional MySQL driver compilation. |
internal/db/inference.go |
Reports compiled drivers. |
internal/db/firebird_connection.go |
Adds conditional Firebird driver compilation. |
internal/db/duckdb_connection.go |
Adds conditional DuckDB driver compilation. |
internal/db/duckdb_connection_stub.go |
Removes the obsolete DuckDB stub. |
internal/db/connection_factory.go |
Centralizes conditional driver creation. |
internal/db/clickhouse_connection.go |
Adds conditional ClickHouse driver compilation. |
flake.nix |
Adds Nix build variants. |
docs/features.md |
Documents variants and driver coverage. |
cmd/squix/drivers.go |
Adds driver availability output. |
cmd/squix/app.go |
Registers the --drivers command. |
build-local.sh |
Builds local variants. |
.github/workflows/release.yml |
Builds and publishes variant releases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.