feat: Get the award content for an offer from the award service#16
Open
berkes wants to merge 1 commit into
Open
feat: Get the award content for an offer from the award service#16berkes wants to merge 1 commit into
berkes wants to merge 1 commit into
Conversation
This implements step 5 and 6 from the https://www.educredentials.eu/ec-issuer/import_in_wallet.html feature. ec-issuer gets award from ec-award ec-award returns award to ec-issuer Furtheremore, this commit includes refactorings to keep consistency across services and their usage. Now that the offer-service calls another service, consistency between those two matters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements step 5 and 6 from the
https://www.educredentials.eu/ec-issuer/import_in_wallet.html feature.
ec-issuer gets award from ec-award
ec-award returns award to ec-issuer
Furtheremore, this commit includes refactorings to keep consistency across services and their usage. Now that the offer-service calls another service, consistency between those two matters.
@153957 We've previously agreed that I would make thomas at least aware of some changes to this service because that's a gradual and pragmatic way to "hand over" and to "introduce" them into this codebase. I've therefore assigned you as reviewer here. Reviewing is mostly "for your info", so that you can see what kind of work is done in this repo and how it is done.
@ThomasKalverda This makes a nice example of how we:
Both: it also shows how ports/adapters can work in Python. What it, IMO, shows very well, is the immense amount of boilerplate and abstractions to do a thing that's in essence very simple: Make a http call to a service and use the json thereof in another call to another service.
In other words: I think it shows us quite well how "un-pythonesque" this setup really is. I am not even close to a python expert, so I'm a poor judge. But I think it shows that this architecture doesn't agree well with Python and vice-versa.
Because, if we boil it down to the very essense, we now need over 1000 lines of code changed, for what could have been one simple
If we ignore or not require tests, typing, error-handling, and a layered/enterprice architecture ;)
I come from rust (and some Java and C# and such) where layering abstractions is common and tooling and language features handle a lot of what we must write "by hand" in python. I think part of the "un-pythonesqe-ishness" comes from me, implementing the abstractions wrong. But I think the largest part comes from the requirement to have such an "enterprise-architecture" in a language/ecosystem, python, that's the antithesis of "enterprice".