Skip to content

Fix error collision #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HepoH3 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix error collision #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ for (i = 0; i < MULTITHREAD; i++)
ee_printf("2K validation run parameters for coremark.\n");
break;
default:
total_errors = -1;
total_errors++;
break;
}
if (known_id >= 0)
Expand Down Expand Up @@ -426,7 +426,7 @@ for (i = 0; i < MULTITHREAD; i++)
}
if (total_errors > 0)
ee_printf("Errors detected\n");
if (total_errors < 0)
if (known_id < 0)

@HepoH3 HepoH3 Feb 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The known_id variable is initialized by -1 and then it reassigned to positive value in switch(seedcrc) block of code. Thus, known_id < 0 is basically the same indicator as current check total_errors < 0, but without error type collision in total_errors variable.

@joseph-yiu joseph-yiu Feb 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the details. I will look into this in a couple of weeks time.
Joseph

@HepoH3 HepoH3 Jun 1, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joseph-yiu, hello!
I see a lot of work is going in nearby issues/PRs. Is there any chance you missed this one?

@joseph-yiu joseph-yiu Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HepoH3 ,
It is still on my list of to-do task.
Sorry for the delay.
Joseph

@joseph-yiu joseph-yiu Jun 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HepoH3 ,
I have reviewed the pull request and am happy with the changes. I have merged it into the development branch dev_2026q3, and will close it when we officially release the new version.
regards,
Joseph

ee_printf(
"Cannot validate operation for these seed values, please compare "
"with results on a known platform.\n");
Expand Down