Drop node.toJSON() methods + reduce options on node.toJS()#664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, nodes had both
.toJS()and.toJSON()methods on each, and the.toJSON()ones were called internally from the.toJS()methods on both the Document as well as parent nodes -- and they didn't necessarily return JSON-compatible values. This was messy, and effectively a remnant of early API decisions that we can now reconsider.This PR drops the
.toJSON()methods from nodes, and simplifies the API for the.toJS()methods. I'm pretty sure that their options didn't actually get any use by anyone.The top-level
doc.toJS()still supports the same options as before, and a (simplified) top-leveldoc.toJSON()is also retained. Its casting of bigints to numbers is dropped.The overall intent here is to reduce the amount of unnecessary work and indirection from parsing.