Repo reorganization v2 (and final, hopefully) - #14
Merged
Conversation
just fixed a typo
…nbad_benchmarks into repo_reorganization
Owner
|
@SteSeg can you remove the .egg-info directory. That should not be included in the git repo and should be added to .gitignore - check the openmc .gitignore to see how. Also remove the DELETE.ipynb file unless you intended for it to be there. |
Collaborator
Author
|
Of course. I just removed those. Also, the fns_clean_w is gonna be ready in ~2 days, alongside with a minor fix in the fns_duct. |
eepeterson
approved these changes
Mar 14, 2024
eepeterson
left a comment
Owner
There was a problem hiding this comment.
Ok thanks for all the good work on this @SteSeg we'll merge what is here and go from there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. Here a PR with (another) reorganization of the repository. Thit time I am quite satisfied with the outcome.
The repo has become a package in order to be able so use some objects more freely. things like, neutron sources, visualization and other postprocessing tools. The code can be found in src/openmc_simbad_benchmarks/. For the moment we have only the fng source but I know there are others out there (some versions of the oktavian for instance).
The other most important folder is models it contains all the benchmarks modeled so far.
In each benchmark folder there are:
openmc_model.py: the actual openmc modelpostprocessing.ipynbnotebook for results visualization and comparisonahelpers.pyile that just helps with postprocessing for the notebook for things that are specific to the benchmark and not generalizable for the source codeThe openmc models that are already present can be run similarly to what @eepeterson proposed in #12 .
I wanted to add a results_database folder in each benchmark folder. In this folder there are all the previous results that were present in sinbad (experimental results, mcnp results). Results format is consistent among all the hdf files: it is possible to call the result/tally in the same way:
Also, those files have several info regarding the experiment/simulation that produced those results:
An important capability I wanted to have is the possibility for users to contribute to the results database. There is indeed a feature able to read the openmc
statepoint.*.h5file, manipulate them in order to be consistent with the database hdf files and store them in a new hdf file in the database folder.My hope is that we can build a database of results able to track the history of the code testing different versions, different nuclear data libraries and different workflows (e.g. DAGMC, UM etc.) against well known benchmark experiments. I believe this is the way to go for validating a community-driven opensource code that evolves so fast.
Currently I am running simulations in order to add the first
openmc_fendl32.h5files in thefng_strandfns_ductdatabases.We have also a notebook/ folder with tutorials.
Last things:
So far, we have only the fng_str and fns_duct benchmarks adapted for this workflow but when we have the green light we can add some more benchmarks and rework the other already existing to be consistent with the workflow.
Among the things I thing we should add the most important in my opinion are:
README.mdfileresults_database/directoriesFinally, my suggestion is to change the name in favor of something more generic as we may want to include new benchmarks that may not be sinbad-related. Something like "openmc fusion benchmarks" I guess.