[Self consistency] Replace DataFrame-based tally conversion with n-D OFB tallies - #84
Closed
SteSeg wants to merge 6 commits into
Closed
[Self consistency] Replace DataFrame-based tally conversion with n-D OFB tallies#84SteSeg wants to merge 6 commits into
SteSeg wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Self consistency] Replace DataFrame-based tally conversion with nD OFB tallies
Summary
This PR removes the intermediate
pandas.DataFramestep when converting OpenMC tallies from astatepointfile tobenchmark_results.h5.Previously, tallies were converted as:
OpenMC tally -> pandas.DataFrame -> xarray.DataArray -> HDF5Because DataFrames are inherently 2D, this imposed shape limitations and made it harder to preserve full tally structure.
With this PR, tallies are handled as true multi-dimensional arrays, consistent with OpenMC and with the OFB specification model.
What changes
BaseTallyandTallyobjects for OFB tally handling.src/openmc_fusion_benchmarks/backends/to support transport-code-specific conversions.src/openmc_fusion_benchmarks/backends/openmc/.scorenuclidefiltersWhy this matters
benchmark_results.h5tally representation with OFB specification semantics.Usage example
Notes for reviewers
This PR is part of a stacked series.
Related PRs in this series use the [Self consistency] prefix.