Use unique temp files for concurrent open workflows#46
Merged
eetann merged 2 commits intoeetann:mainfrom Mar 30, 2026
Merged
Conversation
yuki-yano
force-pushed
the
fix/temp-file-collision
branch
2 times, most recently
from
5bb0905 to
5b0c8c4
Compare
- use mkdtemp to create a dedicated temp workspace per invocation - add tests for empty file creation and unique file paths
yuki-yano
force-pushed
the
fix/temp-file-collision
branch
from
5b0c8c4 to
61affb9
Compare
- use real temp file creation in openEditorAndGetContent tests - clean up generated temp files after each test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes
editprompt openuse a dedicated temporary workspace for each invocation.Previously, temp file paths were generated from a timestamp with second-level resolution under a shared temp directory. That meant multiple
openprocesses started within the same second could end up using the same file and overwrite each other.With this change, each invocation gets its own temp directory via
mkdtemp, and the prompt file is created inside that directory. This avoids temp file collisions without changing the overall open workflow.