refactor(): added tests, and fixednuxterrorboundary in libs,added storybook demo - #821
Merged
MindfulLearner merged 3 commits intoJul 22, 2026
Conversation
MindfulLearner
marked this pull request as draft
July 22, 2026 16:11
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
MindfulLearner
marked this pull request as ready for review
July 22, 2026 16:18
Member
Author
|
Approved by Davide on ds |
MindfulLearner
deleted the
refactor-fixed-nuxt-error-boundary-in-vue-components
branch
July 22, 2026 23:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Extracts
FixedNuxtErrorBoundaryintovue-componentsso it becomes shared and reusable instead of duplicated per project.why
The component existed as independent copies in different consuming repos, each drifting slightly from the others. Centralizing it here means one implementation to maintain.
how
Moved the component unchanged from its original location, ported its existing test suite to pin the current behavior, and added a Storybook story so it can be seen working in isolation.
remarks
vue-routeris added as a peer dependency ofvue-components, since the component uses it at runtime.tested in storybook, and in frontend