ci: use Node 24 latest for OIDC release runners - #825
Merged
Merged
Conversation
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
Member
|
@omegent instead of the workaround, maybe get the runners up to latest 24.x versions? |
Contributor
Author
|
Agreed — better fix is bump the runner Node line, not drop the npm upgrade. Root cause: Change on this PR (
CI already uses After merge, re-apply the live workflow (bot still can’t write under cp .github/release.oidc.yaml .github/workflows/release.yaml
git add .github/workflows/release.yaml
git commit -m "ci: Node 24 latest + npm@latest for OIDC publish"
git push |
Contributor
Author
|
Agreed — aligning the release workflow with latest Node 24.x (CI already uses
|
Pin setup-node to major 24 (latest 24.x) and keep npm@latest. Stale 24.14 pin made npm 12's engine check fail during the CLI upgrade.
omegent-app
Bot
force-pushed
the
fix/oidc-npm-node-engine
branch
from
August 3, 2026 11:09
f1049a8 to
aeeaf9f
Compare
Drop the release.oidc.yaml copy-over template; workflows can be updated directly. Pin Node 24 (latest 24.x) and keep npm@latest on the live Changesets workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Changesets
versionjob failed before publish:npm install -g npm@latestpulled npm 12, which needs Node ≥ 24.15. The runner is on Node 24.14 with npm 11.11.0, which already satisfies OIDC trusted publishing (≥ 11.5.1).This PR updates
.github/release.oidc.yaml(template) to remove that upgrade step.Maintainer action (bot cannot push workflow files)
After merge, or immediately on
main:Then re-run the failed Changesets workflow (or wait for the push).
Test plan
release.yamlno longer runsnpm@latestupgradeNo NPM_TOKEN found, but OIDC is available - using npm trusted publishing