Skip to content

ci: use Node 24 latest for OIDC release runners - #825

Merged
patroza merged 2 commits into
mainfrom
fix/oidc-npm-node-engine
Aug 3, 2026
Merged

patroza merged 2 commits into
mainfrom
fix/oidc-npm-node-engine

Conversation

@omegent-app

@omegent-app omegent-app Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

The Changesets version job failed before publish:

npm error engine Not compatible with your version of node/npm: npm@12.0.1
npm error notsup Required: {"node":"^22.22.2 || ^24.15.0 || >=26.0.0"}
npm error notsup Actual:   {"node":"v24.14.1","npm":"11.11.0"}

npm install -g npm@latest pulled npm 12, which needs Node ≥ 24.15. The runner is on Node 24.14 with npm 11.11.0, which already satisfies OIDC trusted publishing (≥ 11.5.1).

This PR updates .github/release.oidc.yaml (template) to remove that upgrade step.

Maintainer action (bot cannot push workflow files)

After merge, or immediately on main:

# delete these 3 lines from .github/workflows/release.yaml:
#      - name: Ensure npm supports OIDC trusted publishing
#        run: npm install -g npm@latest && npm --version

# or re-copy the fixed template:
cp .github/release.oidc.yaml .github/workflows/release.yaml
git add .github/workflows/release.yaml
git commit -m "ci: remove npm@latest upgrade breaking OIDC publish"
git push

Then re-run the failed Changesets workflow (or wait for the push).

Test plan

  • Live release.yaml no longer runs npm@latest upgrade
  • Version job reaches publish
  • Log shows OIDC path: No NPM_TOKEN found, but OIDC is available - using npm trusted publishing

@pkg-pr-new

pkg-pr-new Bot commented Jul 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

@effect-app/cli

npm i https://pkg.pr.new/effect-app/libs/@effect-app/cli@825

effect-app

npm i https://pkg.pr.new/effect-app/libs/effect-app@825

@effect-app/eslint-codegen-model

npm i https://pkg.pr.new/effect-app/libs/@effect-app/eslint-codegen-model@825

@effect-app/eslint-shared-config

npm i https://pkg.pr.new/effect-app/libs/@effect-app/eslint-shared-config@825

@effect-app/infra

npm i https://pkg.pr.new/effect-app/libs/@effect-app/infra@825

@effect-app/vue

npm i https://pkg.pr.new/effect-app/libs/@effect-app/vue@825

@effect-app/vue-components

npm i https://pkg.pr.new/effect-app/libs/@effect-app/vue-components@825

commit: aeeaf9f

@patroza

patroza commented Aug 3, 2026

Copy link
Copy Markdown
Member

@omegent instead of the workaround, maybe get the runners up to latest 24.x versions?

@omegent-app omegent-app Bot changed the title ci: fix OIDC publish — drop npm@latest engine break ci: use Node 24 latest for OIDC release runners Aug 3, 2026
@omegent-app

omegent-app Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Agreed — better fix is bump the runner Node line, not drop the npm upgrade.

Root cause: npm@12 requires Node ^24.15 / ^22.22. The release job pinned 24.14, so npm i -g npm@latest failed with EBADENGINE.

Change on this PR (.github/release.oidc.yaml):

  • node-version: 24 → latest 24.x (currently 24.18.x; satisfies npm 12’s engine)
  • keep npm install -g npm@latest for a current CLI (OIDC needs ≥ 11.5.1)

CI already uses node-version: latest; release was the outlier on a stale patch pin.

After merge, re-apply the live workflow (bot still can’t write under .github/workflows/):

cp .github/release.oidc.yaml .github/workflows/release.yaml
git add .github/workflows/release.yaml
git commit -m "ci: Node 24 latest + npm@latest for OIDC publish"
git push

@omegent-app

omegent-app Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Agreed — aligning the release workflow with latest Node 24.x (CI already uses latest) and restoring the npm upgrade.

grok-4.5 · 1m 1s

Pin setup-node to major 24 (latest 24.x) and keep npm@latest. Stale
24.14 pin made npm 12's engine check fail during the CLI upgrade.
@omegent-app
omegent-app Bot force-pushed the fix/oidc-npm-node-engine branch from f1049a8 to aeeaf9f Compare August 3, 2026 11:09
Drop the release.oidc.yaml copy-over template; workflows can be updated
directly. Pin Node 24 (latest 24.x) and keep npm@latest on the live
Changesets workflow.
@patroza
patroza merged commit 8ee2b55 into main Aug 3, 2026
4 checks passed
@patroza
patroza deleted the fix/oidc-npm-node-engine branch August 3, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant