Conversation
Eleven tools are declared `-> Dict[str, Any]` but return a bare f-string on the
non-200 branch, and each carries a literal-$ typo (`${response.json()}`), so the
error text renders as e.g. `Cannot fetch agents ${...}` and the return value
violates the declared type (which also trips FastMCP structured-output
validation). Switch them to the dict error idiom already used elsewhere in the
file (e.g. get_ticket_tasks): {"error": <msg>, "details": response.json()}.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Eleven tools are declared
-> Dict[str, Any]but return a bare f-string on the non-200 branch, e.g.:Two issues on that error line:
Dict[str, Any]but returns astr. Under recent MCP/FastMCP versions this trips structured-output validation (the same class of problem fixed forget_ticket_by_idin fix: resolve MCP output schema validation error for get_ticket_by_id #28).$typo —${response.json()}is JS-style interpolation; in a Python f-string the$is literal, so the message renders asCannot fetch agents ${...}.Fix
Switch these error branches to the dict idiom already used elsewhere in the same file (e.g.
get_ticket_tasks):Affected tools:
update_ticket_conversation,list_all_ticket_conversation,get_products_by_id,get_requester_id,list_all_requester_fields,get_agent,update_agent,get_agent_fields,get_all_agent_groups,getAgentGroupById,get_requester_groups_by_id.No behavior change on the success path; only the error branch return shape changes.
🤖 Generated with Claude Code