Open
Conversation
- Row selection (single/multiple) with visual feedback - Column sorting with accessibility support - Row virtualization for large datasets - Built-in pagination and filtering - Full accessibility and keyboard navigation - Custom cell renderers and theming - 22+ Storybook stories with documentation - Design system integration with MIT license compatibility - Production-ready with comprehensive JSDoc documentation
- Componente Table completo con funcionalidades actuales - Selección compleja (selectedKeys, selectionMode, selectionBehavior) - Virtualización y sorting/pagination internos (a refactorizar) - Contenido decorativo (topContent/bottomContent) a eliminar - Base para implementar API-driven approach Estado previo a refactorización para mantener historial completo. Siguiendo planificación detallada de reducción de complejidad.
- Implemented Table component with comprehensive functionality - Added 14 stories showcasing all features and use cases - Included row selection, sorting, pagination, and custom cell rendering - API-driven approach with callbacks for backend integration - Spanish localized examples with realistic data
✅ Deploy Preview for egdev6-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
egdev6
reviewed
Oct 6, 2025
| @@ -0,0 +1,106 @@ | |||
| import { cva } from 'class-variance-authority'; | |||
Owner
There was a problem hiding this comment.
este archivo debería ir dentro de types.ts
| import type { CompleteTableProps, TableColumn } from './types'; | ||
| import { useKeyboardNavigation, useTable, useTableEvents } from './useTable'; | ||
|
|
||
| function Table<T = any>(props: CompleteTableProps<T>) { |
Owner
There was a problem hiding this comment.
las props se reciben en useTable, así como todas las funciones y variables que uses en el componente visual. Mantén en este archivo únicamente la renderización (return) y esas variables usadas como hook. Puede ver ejemplo de otro componentes. sI tienes funciones que devuelven renderización visual si que puedes mantenerlas aquí. El objetivo es separar la parte lógica de la visual
| export type TableLayout = 'auto' | 'fixed'; | ||
|
|
||
| export type ColumnAlign = 'start' | 'center' | 'end'; | ||
|
|
Owner
There was a problem hiding this comment.
Repasa si aquí te falta la documentación por comentarios mdx para storybook (ejemplo en otro componentes tb)
…recciones en la documentación
…ación de los ejemplos implementados
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Componente Table completo con todas las funcionalidades
Pendiente de cualquier corrección o mejora