Give each queued follow-up its own row - #219
Open
shreeve wants to merge 1 commit into
Open
Conversation
shreeve
force-pushed
the
fix/queued-prompt-rows
branch
from
September 9, 2026 17:37
6447a27 to
62017b6
Compare
The queued-message card drew every follow-up in a fixed 30px row with its text vertically centred and only `truncate` to keep it on one line. `truncate` stops soft wrapping, but a hard newline still breaks the text into several lines, and centring those in 30px paints the extra lines over the rows above and below and past the card's top edge. Any multi-line follow-up, a pasted terminal transcript or a file tree, overlapped its neighbours. A row is now its own box: it grows to its text, clips anything past that, top-aligns the queue icon and the controls with the first line, and a rule separates it from the row before. The text keeps its hard line breaks and wraps long lines, up to three lines in all with an ellipsis on the last, so a prompt is recognisable without the queue turning into a second transcript. A one-line row still measures 30px, so the common case looks as it did.
shreeve
force-pushed
the
fix/queued-prompt-rows
branch
from
September 9, 2026 17:41
62017b6 to
bff1c53
Compare
1 task
Contributor
Author
|
The Ubuntu job here fails before any Rust runs: #220 removes that apt source from the workflow, so this PR needs #220 merged first before its CI can complete. Once #220 is in, I'll rebase this branch onto main and CI should go green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Queued follow-ups in the composer painted over each other whenever one of them spanned more than one line.
Each row in the queued-message card was a fixed 30px box with its content vertically centred and
truncateto keep the text on one line.truncateonly stops soft wrapping: a hard newline still breaks the text into several lines, and centring those in 30px draws the extra lines over the rows above and below, and past the card's top edge. Any pasted terminal output or file tree in a follow-up did this.This PR makes each row its own box:
A one-line row still measures 30px, so the common case looks exactly as it did.
Before
Three queued prompts, the first two multi-line. Rows overlap and the first spills above the card:
After
Same three prompts with this change. Each row is bounded, top-aligned, and separated by a rule; the file tree is clamped to three lines:
Test plan
cargo test --lib: 372 passedWaku Debug.appon main with three queued prompts (two multi-line), then confirmed the layout above after the rebuild with the same queue