Repository navigation
Add About button to the top menu - #15
Merged
Merged
Conversation
Adds an About button at the end of the header toolbar, like the other calculators on ehcrea.com. It opens the About page, uses the existing translations in all five languages and is marked aria-current while the About page is open. On phones it shows an info icon with the translated label kept as its accessible name, and below 420px the Saved button does the same so the header fits in every language. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DtSyM4yhAtamTS8M79hwUQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Eren · project thread
Summary
#/aboutpage.Abouttranslation (Über / Acerca de / Over / Hakkında), so all five languages are covered with no new strings.<button>,aria-current="page"and an accent outline while the About page is open, and translated text stays the accessible name.Testing
npm test: 827 passedaria-currentset, and the header no longer overflows. A calculator form card still overflows at 320 to 360px in DE/NL, which was already the case on main.Generated by Claude Code