Fix table context menu actions and dialog-backed cell splitting by alokwhitewolf · Pull Request #243 · eigenpal/docx-editor

alokwhitewolf · 2026-03-31T19:43:56Z

Summary

fix right-click table actions so row/column insert/delete commands actually execute
add Merge cells and Split cell to the right-click table menu
make Split cell dialog-backed with explicit row/column input and unify that behavior across the ProseMirror and legacy table-selection paths
fix a follow-up column insertion bug where adding a row and then a column from the middle of a table could corrupt the table shape
update and extend E2E coverage for the context menu, split flow, and add-column regression

Fixes #242.

Before

right-click table row/column actions did nothing
Merge cells / Split cell were missing from the right-click menu
existing splitCell behavior was closer to unmerge than true row/column split

After

right-click table actions execute correctly
Merge cells and Split cell are available in the right-click menu
Split cell opens a row/column dialog and performs a real structural split

|

Verification

bunx tsc -p packages/react/tsconfig.json --noEmit
npx playwright test e2e/tests/table-context-menu.spec.ts --project=chromium --workers=1
npx playwright test e2e/tests/table-merge-split.spec.ts --project=chromium --workers=1
npx playwright test e2e/tests/table-add-column-regression.spec.ts --project=chromium --workers=1

vercel · 2026-03-31T19:44:01Z

@alokwhitewolf is attempting to deploy a commit to the EigenPal Team on Vercel.

A member of the Team first needs to authorize it.

vercel · 2026-04-01T04:37:34Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docx-editor	Ready	Preview, Comment	Apr 1, 2026 4:37am

jedrazb

Hey @alokwhitewolf, good stuff! Thank you for contributing, I reviewed and left a couple of comments, mostly about code duplication

jedrazb · 2026-04-02T15:48:06Z

@@ -0,0 +1,352 @@
+import type { Node as PMNode } from 'prosemirror-model';


Two things about this file:

Wrong package — this is pure ProseMirror logic with zero React. It should live in packages/core (e.g. alongside TableExtension or in a table utils module), not in packages/react/src/components/.

~350 lines duplicated with TableToolbar.tsx — the anchor collection, column-width splitting, coordinate adjustment, and table rebuild algorithm here is nearly identical to collectDocumentTableAnchors / splitTableColumnWidths / splitTableCell in TableToolbar.tsx. The only difference is the data types (PMNode vs Document-model Table).

Right now any change one path has to be manually mirrored in the other.

jedrazb · 2026-04-02T15:49:25Z

+}
+
+function collectPMTableAnchors(
+  node: PMNode,


This is the third copy of the same anchor-collection algorithm in this PR (also in tableSplit.ts:collectTableAnchors and TableToolbar.tsx:collectDocumentTableAnchors). All three walk the table, build an occupied grid, and produce { row, col, rowspan, colspan } anchors.

The types differ (PMNode vs TableCell) but the grid logic is identical. Worth extracting into a generic helper that takes a row-iterator and a cell-span-getter.

jedrazb · 2026-04-02T15:49:25Z

  const attrs = node.attrs as TableAttrs;
+  const { anchors, totalCols } = collectPMTableAnchors(node, documentCounts);
+  const anchorByStart = new Map<string, PMTableCellAnchor>();
+  const anchorByCoveredSlot = new Map<string, PMTableCellAnchor>();


This anchorByStart / anchorByCoveredSlot + rebuild loop is the same pattern used in tableSplit.ts:splitActiveTableCell and TableToolbar.tsx:splitTableCell. Here it's used for the save round-trip (PM → DOCX), which means it now runs on every table save — not just split operations.

The old convertPMTableRow was simpler but didn't handle post-split merged cells correctly, so the rewrite is justified. Just flagging that this is a hot path — any bug here silently corrupts saved DOCX files. Consider adding a unit test that round-trips a table with mixed merged/unmerged cells through toProseDoc → fromProseDoc and asserts the XML is preserved.

jedrazb · 2026-04-02T15:49:25Z

  const handleEditorContextMenu = useCallback((e: React.MouseEvent) => {
+    const target = e.target as HTMLElement | null;
+    if (target?.closest('.paged-editor__pages')) {
+      return;


This early return means right-clicks on the visible pages now silently skip this handler and rely on PagedEditor's handleContextMenu callback instead. That works, but it's an implicit coupling — if someone removes or changes the PagedEditor handler, the context menu disappears with no error.

A short comment explaining the delegation would help:

// Visible pages handle their own context menu via PagedEditor.handleContextMenu

jedrazb · 2026-04-02T15:49:25Z

+
+  return (
+    <div style={overlayStyle} onClick={onClose} onKeyDown={handleKeyDown}>
+      <div


onKeyDown is on the overlay div, which isn't focusable by default. This works because clicks inside the dialog give focus to the inputs, and key events bubble up. But if the dialog opens and the user hasn't clicked anything yet, Escape/Enter won't fire.

Minor — could add tabIndex={-1} and autoFocus on the dialog container, or move the keydown listener to a useEffect with document.addEventListener.

jedrazb · 2026-04-02T15:49:25Z

+}
+
+export function splitActiveTableCell(
+  state: EditorState,


This is the core split algorithm. The same logic (anchor adjustment loop with deltaRows/deltaCols, band intersection checks, and full table rebuild) is duplicated in TableToolbar.tsx:splitTableCell for the document-model path.

Both are needed because the editor has two table representations (PM nodes vs Document model), but the algorithm is identical — only the data access differs. A bug fix in one needs to be mirrored in the other.

At minimum, add a comment at the top of this function pointing to its counterpart:

// Mirror: TableToolbar.splitTableCell() — same algorithm for the Document-model path

jedrazb · 2026-04-02T15:49:26Z

+}
+
+function collectDocumentTableAnchors(table: Table): {
+  anchors: DocumentTableAnchor[];


This is the document-model counterpart of tableSplit.ts:collectTableAnchors. Same grid-walk algorithm, but reads gridSpan / vMerge (OOXML attributes) instead of PM's colspan / rowspan.

The two functions will need to stay in sync. Add a cross-reference comment so the next person editing one knows to check the other.

…ll splitting Fixes right-click table row/column actions that were non-functional. Adds merge cells and split cell to the context menu with a dialog-backed split cell that accepts explicit row/column counts. Fixes column insertion regression when adding a row then column from mid-table.

Lock file was stale after merging upstream PRs eigenpal#201, eigenpal#243, eigenpal#246, eigenpal#247. Regenerated to include new dependencies (e.g. @happy-dom/global-registrator).

Fixes from code review of PR #243: 1. Restore right-click cursor precision in table cells — the PR snapped the cursor to cell start on right-click, losing the user's click position for cut/copy/paste operations. 2. Capture cell coordinates at dialog-open time and pass them through to the split function — prevents operating on the wrong cell if the user clicks elsewhere while the dialog is open. 3. Add onMouseDown stopPropagation to SplitCellDialog overlay — prevents ProseMirror focus stealing when interacting with dialog inputs. 4. Fix fragile TextSelection offset (+ 2 → + 1) — let TextSelection.near() find the correct position instead of hardcoding an assumption about cell content structure. 5. Add bounds validation (rows/cols >= 1) to both splitActiveTableCell and splitTableCell to guard against zero/negative inputs from the public API. 6. Fix fragile grid column count heuristic in test helper — read from CSS grid-template-columns instead of guessing via Math.sqrt(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…+ review fixes) (#253) * Fix table context menu actions and cell splitting * fix: address stability and correctness issues in table context menu PR Fixes from code review of PR #243: 1. Restore right-click cursor precision in table cells — the PR snapped the cursor to cell start on right-click, losing the user's click position for cut/copy/paste operations. 2. Capture cell coordinates at dialog-open time and pass them through to the split function — prevents operating on the wrong cell if the user clicks elsewhere while the dialog is open. 3. Add onMouseDown stopPropagation to SplitCellDialog overlay — prevents ProseMirror focus stealing when interacting with dialog inputs. 4. Fix fragile TextSelection offset (+ 2 → + 1) — let TextSelection.near() find the correct position instead of hardcoding an assumption about cell content structure. 5. Add bounds validation (rows/cols >= 1) to both splitActiveTableCell and splitTableCell to guard against zero/negative inputs from the public API. 6. Fix fragile grid column count heuristic in test helper — read from CSS grid-template-columns instead of guessing via Math.sqrt(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: extract shared table split algorithm, move ProseMirror split to core The split-cell logic was duplicated between tableSplit.ts (ProseMirror path, 387 lines) and TableToolbar.tsx (Document model path, ~280 lines). Both implemented identical algorithms for anchor collection, column width redistribution, and neighbor span adjustment. Changes: - Extract shared algorithm to packages/core/src/utils/tableSplitAlgorithm.ts (computeSplitLayout, redistributeColumnWidths, buildAnchorMaps, computeSplitDialogDefaults) — generic over cell type via CellAnchor<T> - Move ProseMirror split to packages/core/src/prosemirror/commands/tableSplit.ts where it belongs alongside other PM table commands - Refactor TableToolbar.tsx to use shared algorithm (-120 lines) - Replace tableSplit.ts in react package with thin re-export - Re-export from commands/table.ts for discoverability Net: -442 lines, zero duplication in the core split algorithm. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Alok Kumar Bishoyi <kurdleak.alok@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

jedrazb · 2026-04-10T08:00:27Z

Fixed in #253

Fix table context menu actions and cell splitting

3fa9f5c

vercel bot deployed to Preview April 1, 2026 04:37 View deployment

jedrazb reviewed Apr 2, 2026

View reviewed changes

yash-giantanalytics mentioned this pull request Apr 5, 2026

chore: add changeset for upstream sync release giantanalyticsai/docx-editor#10

Merged

2 tasks

jedrazb mentioned this pull request Apr 10, 2026

fix: table context menu actions and dialog-backed cell splitting (#243 + review fixes) #253

Merged

6 tasks

jedrazb closed this Apr 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix table context menu actions and dialog-backed cell splitting#243

Fix table context menu actions and dialog-backed cell splitting#243
alokwhitewolf wants to merge 1 commit intoeigenpal:mainfrom
alokwhitewolf:fix/table-context-menu-split-cell

alokwhitewolf commented Mar 31, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 31, 2026

Uh oh!

vercel bot commented Apr 1, 2026 •

edited

Loading

Uh oh!

jedrazb left a comment •

edited

Loading

Uh oh!

jedrazb Apr 2, 2026 •

edited

Loading

Uh oh!

jedrazb Apr 2, 2026

Uh oh!

jedrazb Apr 2, 2026

Uh oh!

jedrazb Apr 2, 2026

Uh oh!

jedrazb Apr 2, 2026

Uh oh!

jedrazb Apr 2, 2026

Uh oh!

jedrazb Apr 2, 2026

Uh oh!

jedrazb commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,352 @@
		import type { Node as PMNode } from 'prosemirror-model';

Conversation

alokwhitewolf commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Before

After

Verification

Uh oh!

vercel bot commented Mar 31, 2026

Uh oh!

vercel bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jedrazb left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jedrazb Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jedrazb Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

jedrazb Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

jedrazb Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

jedrazb Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

jedrazb Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

jedrazb Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

jedrazb commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alokwhitewolf commented Mar 31, 2026 •

edited

Loading

vercel bot commented Apr 1, 2026 •

edited

Loading

jedrazb left a comment •

edited

Loading

jedrazb Apr 2, 2026 •

edited

Loading