refactor: move privacy consent from ChatBox to Login/SignUp#1239
Open
eureka928 wants to merge 10 commits intoeigent-ai:mainfrom
Open
refactor: move privacy consent from ChatBox to Login/SignUp#1239eureka928 wants to merge 10 commits intoeigent-ai:mainfrom
eureka928 wants to merge 10 commits intoeigent-ai:mainfrom
Conversation
Create reusable checkbox component following the existing switch.tsx pattern with React.forwardRef and design token classes.
Add agree-to-terms and please-accept-terms keys to all layout.json locale files. Add help-improve-eigent keys to all setting.json files.
Add mandatory terms acceptance checkbox that gates login and OAuth flows. Call acceptPrivacy API after successful authentication.
Add mandatory terms acceptance checkbox that gates registration and OAuth flows. Call acceptPrivacy API after successful OAuth login.
Remove privacy state, API fetch, consent banner, and all privacy checks from ChatBox. Privacy consent is now handled at login.
Remove privacy prop from interface, destructured props, drag-drop guards, and add-file button disabled condition.
Replace the four individual privacy permission toggles with a single optional Help Improve Eigent toggle for telemetry data collection.
Remove privacy-related test cases from ChatBox tests since privacy is now handled at login. Update mocks and assertions accordingly.
Contributor
Author
|
@Wendong-Fan @Pakchoioioi @4pmtong would you review this PR for refactor? Thank you for your time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move privacy consent from a runtime gating mechanism in ChatBox to a mandatory checkbox on the Login and SignUp pages. This simplifies the chat flow by removing the privacy dialog and inline privacy checks, while ensuring users consent before they can proceed.
Closes #934
Changes:
privacyprop from ChatBox and InputBoxhelp_improvefield toUserPrivacySettingsbackend modelsrc/components/ui/checkbox.tsx)Dialog/PrivacycomponentWhat is the purpose of this pull request?