fix: dark mode text contrast in Acceptance Criteria section - #167
Conversation
…x.html) Labels, select boxes, and the section divider under "Acceptance Criteria" had no dark: variant classes, so text rendered in default (light-mode) colors and became unreadable against the dark background. Live site reproduced this in dark mode. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed59e75245
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <details class="mb-8 border-t border-slate-100 pt-6" open> | ||
| <summary class="cursor-pointer text-[10px] font-extrabold text-slate-600 uppercase tracking-widest">Acceptance Criteria</summary> | ||
| <p class="text-[11px] text-slate-500 mt-2 mb-3">Required failures produce FAIL; preferred warnings produce CONDITIONAL PASS.</p> | ||
| <details class="mb-8 border-t border-slate-100 dark:border-slate-800 pt-6" open> |
There was a problem hiding this comment.
Because this is a Web UI bug fix, the repo checklist requires updating the public-facing files for both bug fixes and Web UI changes; this commit only changes web/index.html, so CHANGELOG.md and web/README.md will omit the shipped contrast fix. Please add the required public-surface updates before landing.
AGENTS.md reference: AGENTS.md:L129-L138
Useful? React with 👍 / 👎.
Feasibility Best / GC Target / High CAI rows showed a bare name with no explanation of what each candidate strategy actually does. Reuses the existing descriptions already shown on the profile-selection cards (Optimization Settings) via the same tooltip-container/info-icon pattern, keyed by candidate.id so it works regardless of label text. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 participant
Summary
dark:Tailwind variants, so text rendered in light-mode colors and was unreadable against the dark theme background.dark:text-*/dark:bg-*/dark:border-*classes consistent with the rest of the page.Scope note
border-t border-slate-100at lines ~350/360/390) have the same missing-dark:pattern but were not in scope for this fix — flagging for a possible follow-up pass.Test plan
🤖 Generated with Claude Code