Fix v3.4.5 web interactions and enforce release gates - #176
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4b9a25506
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| npx = "npx.cmd" if sys.platform.startswith("win") else "npx" | ||
| _run_step("web JavaScript syntax", [node, "--check", "web/js/app.js"]) | ||
| _run_step("npm dependencies", [npm, "ci"]) | ||
| _run_step("Playwright", [npx, "playwright", "test"]) |
There was a problem hiding this comment.
On a clean release workstation, npm ci installs the Playwright package but not its Chromium executable, so this newly added call aborts Step 4 instead of exercising the web tests. The equivalent sequence in .github/workflows/e2e.yml explicitly runs npx playwright install --with-deps chromium after npm ci; add a browser-install step here before invoking Playwright so the required release path works without a pre-populated browser cache.
AGENTS.md reference: AGENTS.md:L135-L138
Useful? React with 👍 / 👎.
d4b9a25 to
481b403
Compare
1 participant
Restores all browser interactions by removing the malformed duplicate initialization block. Adds direct release-notes and dark-mode regression coverage, makes E2E blocking, validates JavaScript in Vercel and Docker builds, synchronizes v3.4.5 version surfaces, and replaces release-note statements not traceable to shipped changes. Local verification: 773 pytest passed, 2 skipped; 14 Playwright passed; JavaScript syntax passed; public-surface audit passed.