feat: add server field to allow overwriting server#189
Open
digitalsadhu wants to merge 1 commit intomainfrom
Open
feat: add server field to allow overwriting server#189digitalsadhu wants to merge 1 commit intomainfrom
digitalsadhu wants to merge 1 commit intomainfrom
Conversation
leftieFriele
approved these changes
Jun 6, 2024
leftieFriele
left a comment
leftieFriele
left a comment
There was a problem hiding this comment.
This looks good to me, as it enables user land applications to pass in whatever they want.
wkillerud
approved these changes
Jul 8, 2024
Contributor
wkillerud
left a comment
wkillerud
left a comment
There was a problem hiding this comment.
Could use some documentation, but seems OK to me 👍
Contributor
|
Want to get this merged still @digitalsadhu ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's one idea...