Add native Windows x64 support and end-to-end verification - #3
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic T3 discovery previously rejected Windows, and credential handling relied on Unix permission modes. Add native Windows x64 process inspection, current-user ACL protection, packaged desktop discovery for both ASAR layouts, and hidden background process launches.
Windows discovery checks process ownership and uses Restart Manager to verify the selected desktop server has its own database open before issuing credentials. Tests now use native Windows executable fixtures, cover Unicode paths and ACL rejection, and run in a Windows CI job alongside Linux and macOS. The setup/release work order records the agreed wizard and nightly/stable follow-up work.
Validation on Gideon, Windows 11 x64 build 26200, Node 24.19.0:
Windows support currently requires x64 Node. Process parameter inspection uses bounded reads of version-sensitive NT structures and fails closed on unsupported data. Tests used disposable state and made no model calls or changes to user T3/Codex configurations. The setup wizard, update handoff, and npm publication remain separate work.