Skip to content

Add native Windows x64 support and end-to-end verification - #3

Merged
eimexdev merged 1 commit into
masterfrom
t3code/design-npm-setup-wizard
Sep 11, 2026
Merged

eimexdev merged 1 commit into
masterfrom
t3code/design-npm-setup-wizard

Conversation

@eimexdev

Copy link
Copy Markdown
Owner

Automatic T3 discovery previously rejected Windows, and credential handling relied on Unix permission modes. Add native Windows x64 process inspection, current-user ACL protection, packaged desktop discovery for both ASAR layouts, and hidden background process launches.

Windows discovery checks process ownership and uses Restart Manager to verify the selected desktop server has its own database open before issuing credentials. Tests now use native Windows executable fixtures, cover Unicode paths and ACL rejection, and run in a Windows CI job alongside Linux and macOS. The setup/release work order records the agreed wizard and nightly/stable follow-up work.

Validation on Gideon, Windows 11 x64 build 26200, Node 24.19.0:

  • All 32 tests passed with both elevated SSH and a non-administrator interactive token; TypeScript checking passed.
  • Isolated end-to-end proofs passed against npm T3 0.0.40 and desktop 0.0.41-nightly.20260911.1551: discovery, credentials, detached-worker renewal/delivery, running-turn steering, and command deduplication.
  • Real Codex 0.154.0 exposed no t3poll tools by default and exposed list/stop/watch with the T3 launch override.
  • Installed the npm tarball in a path with spaces and non-ASCII characters, then passed the npm T3 and real Codex proofs using that installed package.
  • Linux: all 30 applicable tests passed; the two Windows-only tests skipped.

Windows support currently requires x64 Node. Process parameter inspection uses bounded reads of version-sensitive NT structures and fails closed on unsupported data. Tests used disposable state and made no model calls or changes to user T3/Codex configurations. The setup wizard, update handoff, and npm publication remain separate work.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 12d81617-dcf5-40fa-a2d5-779627c18066


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T23:13:12.534251Z f13e68a PR opened
🔒 Security Review Completed 2026-09-11T23:21:16.461308Z f13e68a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@eimexdev
eimexdev merged commit 031a6a1 into master Sep 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant