Skip to content

Conversation

@eirnym
Copy link
Contributor

@eirnym eirnym commented Apr 14, 2025

Closes #4

Notes on implementation and differences with proposition:

Name generation:

  • There's no special subtest variant
  • There's no tests which has specifications for encoding or endian
  • Error list is limited separated out by it's own id
  • Error id is included in function name for read-rejected tests.
  • Actual constant name generation is slightly changed from proposed

Test data and metadata:

  • Documentation should be implemented per-test-case if any.
  • Data split into 3 files:
    • layouts — common for every test
    • accepted — data for r/w accepted tests
    • rejected — data for read rejected tests
    • Data for write rejected tests is not separated out because there's only 3 strings

Possible future to-do (low priority):

  • per-test-case documentation — could be done as module documentation where data is located
  • More information on reasoning of write-io-rejected tests.
  • extract actual functions? This would potentially work only for for accepted tests for read/write.

You're welcome to create PR if any additional work on tests is needed, including list from possible future to-do list.

@github-actions
Copy link

github-actions bot commented Apr 14, 2025

TestsPassed ✅SkippedFailed
Deku String292 ran292 passed0 skipped0 failed

@github-actions
Copy link

github-actions bot commented Apr 14, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
201 201 100% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: f102303 by action🐍

@eirnym eirnym force-pushed the test-refactoring branch from 75477d7 to f102303 Compare April 14, 2025 12:24
@eirnym eirnym merged commit c13fe48 into main Apr 14, 2025
8 checks passed
@eirnym eirnym deleted the test-refactoring branch April 14, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat (refactor): more robust test cases

2 participants