Repository navigation
fix: tell new_device whether the device is alone on its port - #20
Merged
Merged
Conversation
A phone joining the router's Wi-Fi was reported as a new device on the port towards the router. new_device now carries devices_on_port and direct; the blueprint reports only devices plugged in directly unless turned off, and says "seen via port" otherwise. Fixes #19 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new_devicenamed the port where a switch learned a MAC address, also when that port only leads to a router: a phone joining the router's Wi-Fi was "new on port 1". A switch cannot tell the router port by itself here (no LLDP from the router, no routing table over SNMP on the 1920S).The event now carries
devices_on_portanddirect(alone on its port). The blueprint gets Only devices plugged in directly (on by default); with it off, shared ports are reported as "seen via port 1 (with 13 other devices)".Fixes #19
Also:
docs/card.mdand its screenshot show the card's new link symbol (⇄, managed-switch-card 0.1.1, eizedev/managed-switch-card#9).Test plan
uv run pytest --cov(87 passed, 100 %),uv run mypy,uv run ruff check .passdirectstrings.jsonand both translations — no new textsCHANGELOG.md,docs/events.mdupdated🤖 Generated with Claude Code