Route "module" not found after Refactoring of Routing

[TheR00st3r]

Hi,

I tried to use this plugin (and some others) together with the latest commit of webtrees.
I think the refactoring of the routing (did not verify with a previous commit) causes some troubles if Primer Theme is enabled: fisharebest/webtrees@58f2f02

InvalidArgumentException: Route "module" not found. in /app/Http/Routing/RouteCollection.php:85
Stack trace:
#0 /app/Factories/RouteFactory.php(60): Fisharebest\Webtrees\Http\Routing\RouteCollection->get()
#1 /app/Helpers/functions.php(93): Fisharebest\Webtrees\Factories\RouteFactory->route()
#2 /modules_v4/webtrees-primer-theme/PrimerTheme.php(184): route()
#3 /modules_v4/webtrees-primer-theme/PrimerTheme.php(93): Primer\PrimerTheme->menuPalette()
#4 /resources/views/layouts/default.phtml(102): Primer\PrimerTheme->userMenu()
#5 /app/View.php(163): include('/var/www/vhosts...')
#6 /app/View.php(239): Fisharebest\Webtrees\View->render()
#7 /app/Helpers/functions.php(103): Fisharebest\Webtrees\View::make()
#8 /app/Http/ViewResponseTrait.php(51): view()
#9 /app/Http/Controllers/UserPage.php(66): Fisharebest\Webtrees\Http\Controllers\UserPage->viewResponse()
#10 [internal function]: Fisharebest\Webtrees\Http\Controllers\UserPage->get()
#11 /app/Http/Routing/ControllerDispatcher.php(81): ReflectionMethod->invoke()
#12 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Routing\ControllerDispatcher->process()
#13 /app/Module/HitCountFooterModule.php(135): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#14 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Module\HitCountFooterModule->process()
#15 /app/Module/CheckForNewVersion.php(101): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#16 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Module\CheckForNewVersion->process()
#17 /app/Http/Middleware/CheckCsrf.php(71): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#18 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\CheckCsrf->process()
#19 /app/Http/Middleware/AuthLoggedIn.php(41): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#20 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\AuthLoggedIn->process()
#21 /app/Http/Dispatcher.php(47): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#22 /app/Http/Middleware/Router.php(114): Fisharebest\Webtrees\Http\Dispatcher::dispatch()
#23 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\Router->process()
#24 /app/Http/Middleware/BootModules.php(45): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#25 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\BootModules->process()
#26 /app/Http/Middleware/RegisterGedcomTags.php(42): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#27 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\RegisterGedcomTags->process()
#28 /app/Http/Middleware/LoadRoutes.php(60): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#29 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\LoadRoutes->process()
#30 /app/Http/Middleware/CheckForNewVersion.php(45): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#31 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\CheckForNewVersion->process()
#32 /app/Http/Middleware/UseTransaction.php(36): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#33 /vendor/illuminate/database/Concerns/ManagesTransactions.php(35): Fisharebest\Webtrees\Http\Middleware\UseTransaction::{closure:Fisharebest\Webtrees\Http\Middleware\UseTransaction::process():35}()
#34 /app/Http/Middleware/UseTransaction.php(35): Illuminate\Database\Connection->transaction()
#35 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\UseTransaction->process()
#36 /app/Http/Middleware/DoHousekeeping.php(59): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#37 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\DoHousekeeping->process()
#38 /app/Http/Middleware/UseTheme.php(54): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#39 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\UseTheme->process()
#40 /app/Http/Middleware/CheckForMaintenanceMode.php(47): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#41 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\CheckForMaintenanceMode->process()
#42 /app/Http/Middleware/UseLanguage.php(52): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#43 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\UseLanguage->process()
#44 /app/Http/Middleware/UseSession.php(74): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#45 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\UseSession->process()
#46 /app/Http/Middleware/UpdateDatabaseSchema.php(46): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#47 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\UpdateDatabaseSchema->process()
#48 /app/Http/Middleware/DebugLogger.php(39): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#49 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\DebugLogger->process()
#50 /app/Http/Middleware/UseDatabase.php(47): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#51 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\UseDatabase->process()
#52 /app/Http/Middleware/BadBotBlocker.php(1641): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#53 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\BadBotBlocker->process()
#54 /app/Http/Middleware/CompressResponse.php(55): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#55 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\CompressResponse->process()
#56 /app/Http/Middleware/ContentLength.php(31): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#57 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\ContentLength->process()
#58 /vendor/middlewares/client-ip/src/ClientIp.php(68): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#59 /app/Http/Middleware/ClientIp.php(38): Middlewares\ClientIp->process()
#60 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\ClientIp->process()
#61 /app/Http/Middleware/PublicFiles.php(59): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#62 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\PublicFiles->process()
#63 /app/Http/Middleware/HandleExceptions.php(79): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#64 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\HandleExceptions->process()
#65 /app/Http/Middleware/SecurityHeaders.php(40): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#66 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\SecurityHeaders->process()
#67 /app/Http/Middleware/BaseUrl.php(64): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#68 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\BaseUrl->process()
#69 /app/Http/Middleware/ReadConfigIni.php(54): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#70 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\ReadConfigIni->process()
#71 /app/Http/Middleware/EmitResponse.php(52): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#72 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\EmitResponse->process()
#73 /app/Http/Middleware/ErrorHandler.php(38): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#74 /app/Http/Dispatcher.php(76): Fisharebest\Webtrees\Http\Middleware\ErrorHandler->process()
#75 /app/Http/Dispatcher.php(47): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#76 /app/Webtrees.php(284): Fisharebest\Webtrees\Http\Dispatcher::dispatch()
#77 /app/Webtrees.php(257): Fisharebest\Webtrees\Webtrees->httpRequest()
#78 /index.php(24): Fisharebest\Webtrees\Webtrees->run()
#79 {main}

[ekdahl]

Looks like this

webtrees-primer-theme/PrimerTheme.php

Line 184 in 1423aae

$url = route('module', ['module' => $this->name(), 'action' => 'Palette', 'palette' => $palette_id]);

should be like this

$url = route(ModuleAction::class, ['module' => $this->name(), 'action' => 'Palette', 'palette' => $palette_id]);

in the upcoming version of webtrees.

[TheR00st3r]

I think this is not enough.

This result into InvalidArgumentException: Route "Primer\ModuleAction" not found.

Maybe I have some time todays evening to look into it.

[ekdahl]

This also needs to be added:

use Fisharebest\Webtrees\Http\RequestHandlers\ModuleAction;

[TheR00st3r]

That makes sense. Now it works.

[ekdahl]

I will keep the work in progress stuff for the next webtrees version in this branch until it is released.