Skip to content

Add ball-table resolver strategies #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekiefl merged 3 commits into from
May 18, 2026

Revert ball-table strategies to be Dim.3D

02967db
Select commit
Loading
Failed to load commit list.
Merged

Add ball-table resolver strategies #297

Revert ball-table strategies to be Dim.3D
02967db
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 18, 2026 in 0s

47.81% (+0.36%) compared to 0d674f7

View this Pull Request on Codecov

47.81% (+0.36%) compared to 0d674f7

Details

Codecov Report

❌ Patch coverage is 75.53957% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.81%. Comparing base (0d674f7) to head (02967db).

Files with missing lines Patch % Lines
...esolve/ball_table/frictional_inelastic/__init__.py 52.08% 23 Missing ⚠️
pooltool/physics/resolve/ball_table/core.py 84.61% 6 Missing ⚠️
pooltool/physics/resolve/resolver.py 42.85% 4 Missing ⚠️
pooltool/physics/utils.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   47.45%   47.81%   +0.36%     
==========================================
  Files         153      157       +4     
  Lines       10493    10631     +138     
==========================================
+ Hits         4979     5083     +104     
- Misses       5514     5548      +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov