Skip to content

Delete detector strategy design #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekiefl merged 2 commits into from
May 18, 2026

Add TODO on introspection

78dae4c
Select commit
Loading
Failed to load commit list.
Merged

Delete detector strategy design #299

Add TODO on introspection
78dae4c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 18, 2026 in 1s

47.61% (-0.27%) compared to 80a675f, passed because coverage increased by 0.53% when compared to adjusted base (47.08%)

View this Pull Request on Codecov

47.61% (-0.27%) compared to 80a675f, passed because coverage increased by 0.53% when compared to adjusted base (47.08%)

Details

Codecov Report

❌ Patch coverage is 90.97744% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.61%. Comparing base (80a675f) to head (78dae4c).

Files with missing lines Patch % Lines
pooltool/evolution/event_based/detect/detector.py 68.75% 5 Missing ⚠️
...ltool/evolution/event_based/detect/ball_cushion.py 92.50% 3 Missing ⚠️
pooltool/evolution/event_based/detect/ball_ball.py 91.66% 2 Missing ⚠️
...oltool/evolution/event_based/detect/ball_pocket.py 95.00% 1 Missing ⚠️
...ooltool/evolution/event_based/detect/ball_table.py 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   47.87%   47.61%   -0.27%     
==========================================
  Files         158      158              
  Lines       10658    10626      -32     
==========================================
- Hits         5103     5060      -43     
- Misses       5555     5566      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov