Skip to content

Add PE to ball energy#301

Merged
ekiefl merged 2 commits into
mainfrom
ek/include-potential-energy-in-get-ball-energy
May 19, 2026
Merged

Add PE to ball energy#301
ekiefl merged 2 commits into
mainfrom
ek/include-potential-energy-in-get-ball-energy

Conversation

@ekiefl
Copy link
Copy Markdown
Owner

@ekiefl ekiefl commented May 19, 2026

Include potential energy in get_ball_energy

  • get_ball_energy now adds gravitational PE (m*g*(z-R)) so airborne balls at
    apex (vz=0) are no longer reported as zero-energy. All callers updated to pass g.
  • _system_has_energy switches to a > 0 check on total mechanical energy.
  • Introspection's cache→events reconstruction now handles BALL_TABLE (was a TODO).
  • Mark CanonicalTransition and CanonicalBallPocket resolvers as Dim.BOTH.
  • Drop the _empty_cue workaround in sandbox/airborne_demos.py (no longer needed
    now that apex states register as having energy).

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 88c75e57-7385-4aa5-a513-b04bacca29f1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ek/include-potential-energy-in-get-ball-energy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 47.70%. Comparing base (0ace05c) to head (fd9fa1a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pooltool/evolution/event_based/detect/detector.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   47.68%   47.70%   +0.01%     
==========================================
  Files         158      158              
  Lines       10642    10646       +4     
==========================================
+ Hits         5075     5079       +4     
  Misses       5567     5567              
Flag Coverage Δ
service 47.70% <91.66%> (+0.01%) ⬆️
service-no-ani 58.15% <91.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ekiefl ekiefl merged commit 3bcd8ec into main May 19, 2026
12 checks passed
@ekiefl ekiefl deleted the ek/include-potential-energy-in-get-ball-energy branch May 19, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant