Add PE to ball energy#301
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 47.68% 47.70% +0.01%
==========================================
Files 158 158
Lines 10642 10646 +4
==========================================
+ Hits 5075 5079 +4
Misses 5567 5567
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Include potential energy in
get_ball_energyget_ball_energynow adds gravitational PE (m*g*(z-R)) so airborne balls atapex (vz=0) are no longer reported as zero-energy. All callers updated to pass
g._system_has_energyswitches to a> 0check on total mechanical energy.BALL_TABLE(was a TODO).CanonicalTransitionandCanonicalBallPocketresolvers asDim.BOTH._empty_cueworkaround insandbox/airborne_demos.py(no longer needednow that apex states register as having energy).