Skip to content

[Snyk] Security upgrade eslint from 2.13.1 to 8.0.0#13

Open
ekmixon wants to merge 1 commit into
masterfrom
snyk-fix-d09c7885a4f8a990ea631ea3012a176d
Open

[Snyk] Security upgrade eslint from 2.13.1 to 8.0.0#13
ekmixon wants to merge 1 commit into
masterfrom
snyk-fix-d09c7885a4f8a990ea631ea3012a176d

Conversation

@ekmixon
Copy link
Copy Markdown
Owner

@ekmixon ekmixon commented May 14, 2022

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 696/1000
Why? Proof of Concept exploit, Has a fix available, CVSS 7.5
Regular Expression Denial of Service (ReDoS)
SNYK-JS-ANSIREGEX-1583908
Yes Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: eslint The new version differs by 250 commits.
  • c4fffbc 8.0.0
  • d51f4cf Build: changelog update for 8.0.0
  • 7d3f7f0 Upgrade: unfrozen @ eslint/eslintrc (fixes #15036) (#15146)
  • 2174a6f Fix: require-atomic-updates property assignment message (fixes #15076) (#15109)
  • f885fe0 Docs: add note and example for extending the range of fix (refs #13706) (#13748)
  • 3da1509 Docs: Add jsdoc `type` annotation to sample rule (#15085)
  • 68a49a9 Docs: Update Rollup Integrations (#15142)
  • d867f81 Docs: Remove a dot from curly link (#15128)
  • 9f8b919 Sponsors: Sync README with website
  • 4b08f29 Sponsors: Sync README with website
  • ebc1ba1 Sponsors: Sync README with website
  • 2d654f1 Docs: add example .eslintrc.json (#15087)
  • 16034f0 Docs: fix fixable example (#15107)
  • 07175b8 8.0.0-rc.0
  • 71faa38 Build: changelog update for 8.0.0-rc.0
  • 67c0074 Update: Suggest missing rule in flat config (fixes #14027) (#15074)
  • cf34e5c Update: space-before-blocks ignore after switch colons (fixes #15082) (#15093)
  • c9efb5f Fix: preserve formatting when rules are removed from disable directives (#15081)
  • 14a4739 Update: `no-new-func` rule catching eval case of `MemberExpression` (#14860)
  • 7f2346b Docs: Update release blog post template (#15094)
  • fabdf8a Chore: Remove `target.all` from `Makefile.js` (#15088)
  • e3cd141 Sponsors: Sync README with website
  • 05d7140 Chore: document target global in Makefile.js (#15084)
  • 0a1a850 Update: include `ruleId` in error logs (fixes #15037) (#15053)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-ANSIREGEX-1583908
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.json : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants