Potential fix for #38#45
Open
geoffdutton wants to merge 250 commits into
Open
Conversation
Author
|
Instead of reloading the whole tab, we can just make sure they've been added to the |
madeline03
approved these changes
Jul 23, 2017
|
Yes |
el1t
force-pushed
the
safari
branch
7 times, most recently
from
January 13, 2018 22:55
4e2a6da to
263502f
Compare
- (githubusercontent.com cannot be accessed from iran
Bind before setting prototype
Use vAPI.getURL to filter details.file in vAPI.tabs.injectScript. Also moved some scripts around.
Extension should list Raymond Hill and Ellis Tsung, not that other guy
|
You might want to rebase and fix the errors. |
# Conflicts: # .github/ISSUE_TEMPLATE.md # CONTRIBUTING.md # README.md # dist/README.md # src/about.html # src/js/dynamic-net-filtering.js # src/settings.html
Instead of chrome’s manifest version
…Block into safari-reload-tabs-on-load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when I inspect the global page and run
window.location.reload(), it's as though all the tabs lose reference to the background page. So one idea would be to reload each tab as we build out thevAPI.tabs.stackobject. Maybe this has something to do with #38?However, this could be a problem if for some reason it kept restarting, or if it restarted when someone was in the middle of something.
Just an idea.