fix(combat-trainer): tie gem pouch at 70 gems instead of swapping#7356
Merged
MahtraDR merged 3 commits intoelanthia-online:mainfrom Mar 26, 2026
Merged
fix(combat-trainer): tie gem pouch at 70 gems instead of swapping#7356MahtraDR merged 3 commits intoelanthia-online:mainfrom
MahtraDR merged 3 commits intoelanthia-online:mainfrom
Conversation
The "tie it up before putting" message fires at 70 gems, meaning the pouch just needs tying to continue filling (up to 500). Previously this was lumped into the pouch-full flag, which triggered a full pouch swap -- dropping the gem, removing/stowing the pouch, getting a spare, then failing to tie the empty replacement. Split into a separate pouch-needs-tie flag that simply ties the current pouch and re-stows the gem. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The hard-coded 'stow gem' didn't match actual gem nouns like 'sunstone' or 'opal', causing the game to try picking up from the ground instead of stowing from hand. Check GameObj hands for the item noun and prepend 'my' to disambiguate. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pouch-fullflag, triggering a full pouch swap -- drop gem, remove pouch, stow it, get spare, wear spare, fail to tie the empty one.pouch-needs-tieflag that simply ties the current pouch and re-stows the gem.Test plan
pouch-needs-tieflag cleanup on script exit🤖 Generated with Claude Code