Skip to content

chore: update mysql2#5136

Merged
trentm merged 2 commits into
mainfrom
chore-update-mysql2
Jul 6, 2026
Merged

chore: update mysql2#5136
trentm merged 2 commits into
mainfrom
chore-update-mysql2

Conversation

@david-luna

Copy link
Copy Markdown
Member

Follow up of #5094. It includes the version checking for tests.

@david-luna
david-luna requested a review from a team as a code owner July 6, 2026 14:41
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

trentm
trentm previously approved these changes Jul 6, 2026
@trentm
trentm enabled auto-merge (squash) July 6, 2026 15:05
@trentm
trentm disabled auto-merge July 6, 2026 15:07
@trentm

trentm commented Jul 6, 2026

Copy link
Copy Markdown
Member

Oh, I missed that test-vers (14.17) is still failing.

@david-luna

Copy link
Copy Markdown
Member Author

I missed there is another test file 🤦

running test: node --unhandled-rejections=strict test/instrumentation/modules/mysql2/mysql.test.js
# SKIP mysql2@3.22.3 does not support node v14.17.6
running test: node --unhandled-rejections=strict test/instrumentation/modules/mysql2/pool-release-1.test.js
{"log.level":"info","@timestamp":"2026-07-06T14:48:55.689Z","log.logger":"elastic-apm-node","ecs.version":"8.10.0","agentVersion":"4.17.0","env":{"pid":9614,"proctitle":"node","os":"linux 6.17.0-1018-azure","arch":"x64","host":"runnervmkkn4f","timezone":"UTC+00","runtime":"Node.js v14.17.6"},"config":{"captureExceptions":{"source":"start","value":false},"centralConfig":{"source":"start","value":false},"logLevel":{"source":"default","value":"info","commonName":"log_level"},"metricsInterval":{"source":"start","value":0},"serverUrl":{"source":"default","value":"http://127.0.0.1:8200/","commonName":"server_url"},"secretToken":{"source":"start","value":"[REDACTED]","commonName":"secret_token"},"serviceName":{"source":"start","value":"test","commonName":"service_name"},"serviceVersion":{"source":"default","value":"4.17.0","commonName":"service_version"}},"activationMethod":"require","message":"Elastic APM Node.js Agent v4.17.0"}
internal/modules/cjs/loader.js:892

@trentm
trentm merged commit 884e8a4 into main Jul 6, 2026
20 checks passed
@trentm
trentm deleted the chore-update-mysql2 branch July 6, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants