Skip to content

fix(bk): serverless-beats-tests start failing after merging #10734#10906

Merged
v1v merged 3 commits into
elastic:mainfrom
v1v:fix/beats-agent-serverless-tests-2
Oct 30, 2025
Merged

fix(bk): serverless-beats-tests start failing after merging #10734#10906
v1v merged 3 commits into
elastic:mainfrom
v1v:fix/beats-agent-serverless-tests-2

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented Oct 29, 2025 •
edited
Loading

What does this PR do?

Restore the previous environmental context for the serverless-beats-tests
Run serverless-beats-tests if touching some of the core files.

Why is it important?

Regression, and help with early detection

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

NA

Only in the CI

This PR triggered:

image

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@v1v v1v self-assigned this Oct 29, 2025
@v1v v1v requested a review from a team as a code owner October 29, 2025 17:36
@v1v v1v requested a review from a team as a code owner October 29, 2025 17:36
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Oct 29, 2025

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

ycombinator
ycombinator previously approved these changes Oct 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd also like @pchila to review as he's currently working on trying to improve our CI times.

@ycombinator ycombinator requested a review from pchila October 29, 2025 17:40
fr4nc1sc0-r4m0n
fr4nc1sc0-r4m0n previously approved these changes Oct 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing that @v1v!

v1v
v1v commented Oct 29, 2025
View reviewed changes
Comment thread .buildkite/pipeline.yml Outdated
pchila
pchila reviewed Oct 29, 2025
View reviewed changes
Comment thread .buildkite/pipeline.yml
@fr4nc1sc0-r4m0n
Copy link
Copy Markdown
Contributor

fr4nc1sc0-r4m0n commented Oct 29, 2025

We should backport this change to all active branches, right?

This was referenced Oct 29, 2025
Merged
Merged
Merged
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 29, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @v1v

@v1v v1v added the backport-active-all Automated backport with mergify to all the active branches label Oct 30, 2025
@v1v v1v merged commit 0a1cf18 into elastic:main Oct 30, 2025
23 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 30, 2025

@Mergifyio backport 8.19 9.1 9.2

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Oct 30, 2025 •
edited
Loading

backport 8.19 9.1 9.2

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Oct 30, 2025
@v1v @mergify
fix(bk): serverless-beats-tests start failing after merging #10734 (#…
087390b 
…10906)

(cherry picked from commit 0a1cf18)

# Conflicts:
#	.buildkite/hooks/pre-command
#	.buildkite/pipeline.yml
@mergify mergify Bot mentioned this pull request Oct 30, 2025
Merged
8 tasks
mergify Bot pushed a commit that referenced this pull request Oct 30, 2025
@v1v @mergify
fix(bk): serverless-beats-tests start failing after merging #10734 (#…
9ef66ec 
…10906)

(cherry picked from commit 0a1cf18)

# Conflicts:
#	.buildkite/pipeline.yml
mergify Bot pushed a commit that referenced this pull request Oct 30, 2025
@v1v @mergify
fix(bk): serverless-beats-tests start failing after merging #10734 (#…
a6b1f51 
…10906)

(cherry picked from commit 0a1cf18)
This was referenced Oct 30, 2025
Merged
Merged
v1v pushed a commit that referenced this pull request Oct 30, 2025
@mergify
[9.1] (backport #10906) fix(bk): serverless-beats-tests start failing…
c6667ea 
… after merging #10734 (#10920)
v1v pushed a commit that referenced this pull request Oct 30, 2025
@mergify
fix(bk): serverless-beats-tests start failing after merging #10734 (#…
59e6509 
…10906) (#10921)
v1v pushed a commit that referenced this pull request Oct 30, 2025
@mergify
[8.19] (backport #10906) fix(bk): serverless-beats-tests start failin…
b561361 
…g after merging #10734 (#10919)
hayotbisonai pushed a commit to hayotbisonai/elastic-agent that referenced this pull request Nov 23, 2025
@v1v @hayotbisonai
fix(bk): serverless-beats-tests start failing after merging elastic#1…
620ab13 
…0734 (elastic#10906)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmacknz cmacknz cmacknz left review comments

@ebeahan ebeahan ebeahan left review comments

@pchila pchila pchila left review comments

@fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n fr4nc1sc0-r4m0n approved these changes

@ycombinator ycombinator ycombinator left review comments

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@v1v v1v

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@v1v @fr4nc1sc0-r4m0n @elasticmachine @ycombinator @cmacknz @ebeahan @pchila