Skip to content
This repository was archived by the owner on Apr 13, 2026. It is now read-only.

Added tags aggregation in SearchController for .NET Core example - #29

Open
rdcm wants to merge 1 commit into
elastic:6.x-codecomplete-netcorefrom
rdcm:tags_aggregation
Open

Added tags aggregation in SearchController for .NET Core example#29
rdcm wants to merge 1 commit into
elastic:6.x-codecomplete-netcorefrom
rdcm:tags_aggregation

Conversation

@rdcm

@rdcm rdcm commented Jul 27, 2018

Copy link
Copy Markdown

No description provided.

@russcam russcam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @rdcm!

Before this can be merged, the README walkthrough would also need to be updated to reflect the changes within the code, since the two are intended to be used together.

Is this something that you would be able to address?

@rdcm

rdcm commented Jul 31, 2018

Copy link
Copy Markdown
Author

@russcam i take this code from branch
https://github.com/elastic/elasticsearch-net-example/blob/5.x-codecomplete-netcore-modifications/src/NuSearch.Web/Modules/Search/Search/SearchController.cs

with little bit refactoring.

Readme in 5.x-codecomplete-netcore-modifications branch not reflect the real code in controller, not contains Apply.. methods and tags aggregations description. I'm not sure I can describe it well. But without this feature sample does not look complete.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants