[Fleet] Mark agent as offline when last_checkin_status is disconnected#262334
Conversation
|
Pinging @elastic/fleet (Team:Fleet) |
ApprovabilityVerdict: Needs human review This PR changes runtime behavior by adding a new 'disconnected' status value and modifying agent status computation to mark disconnected agents as 'offline'. Since this affects how agents are classified in production and the author doesn't own any of the modified Fleet files (owned by @elastic/fleet), human review by the code owners is appropriate. You can customize Macroscope's approvability policy. Learn more. |
juliaElastic
left a comment
There was a problem hiding this comment.
The change looks good, it would be good to add integration tests in fleet_api_integration to verify that the ES query works correctly with test agent documents. Claude can help generate it.
e40c7c4 to
73a2954
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis change extends agent status handling throughout the Fleet system by introducing ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Comment |
|
@elastic/ski-docs, can I please get a review? |
|
Starting backport for target branches: 9.4 |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
Adds a
disconnectedcheck to the agent status runtime field Painless script so that agents are markedofflineimmediately when fleet-server reportslast_checkin_status: disconnected, rather than waiting for the time-based offline threshold.Related fleet-server change: elastic/fleet-server#6792
Related issue: elastic/fleet-server#6784