Skip to content

bump jruby to 9.2.12.0 - #12071

Merged
elasticsearch-bot merged 1 commit into
elastic:masterfrom
jsvd:bump_jruby_9_2_12_0
Jul 8, 2020
Merged

bump jruby to 9.2.12.0#12071
elasticsearch-bot merged 1 commit into
elastic:masterfrom
jsvd:bump_jruby_9_2_12_0

Conversation

@jsvd

@jsvd jsvd commented Jul 1, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Also tweak the documentation since most of the add-opens are no longer needed, except two:

@jsvd

jsvd commented Jul 2, 2020

Copy link
Copy Markdown
Member Author

jenkins test this please

@jsvd
jsvd force-pushed the bump_jruby_9_2_12_0 branch 2 times, most recently from fd7ece4 to 4b49902 Compare July 3, 2020 15:32
@jsvd

jsvd commented Jul 3, 2020

Copy link
Copy Markdown
Member Author

@kares looking at the jruby 9.2.12.0 release notes:

The last remaining triggers of the “Illegal access” warnings and errors in JRuby core have been fixed. JRuby will avoid accessing Java modules and packages that have not been exported or opened. (#6195, #6287, #6298, #6299)

But we still have one in logstash startup for org.jruby.ext.openssl.SecurityHelper:

❯ bin/logstash -e ""
OpenJDK 64-Bit Server VM warning: Option UseConcMarkSweepGC was deprecated in version 9.0 and will likely be removed in a future release.
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.jruby.ext.openssl.SecurityHelper (file:/var/folders/cg/p_vcxtdj32d4ssw5cz3n43th0000gn/T/jruby-39776/jruby6561733352138861814jopenssl.jar) to field java.security.MessageDigest.provider
WARNING: Please consider reporting this to the maintainers of org.jruby.ext.openssl.SecurityHelper
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
Sending Logstash logs to /Users/joaoduarte/elastic/logstash/build/logstash-8.0.0-SNAPSHOT/logs which is now configured via log4j2.properties
[2020-07-03T16:57:10,917][WARN ][logstash.config.source.multilocal] Ignoring the 'pipelines.yml' file because modules or command line options are specified
[2020-07-03T16:57:11,025][INFO ][logstash.runner          ] Starting Logstash {"logstash.version"=>"8.0.0", "jruby.version"=>"jruby 9.2.12.0 (2.5.7) 2020-07-01 db01a49ba6 OpenJDK 64-Bit Server VM 11.0.5+10 on 11.0.5+10 +indy +jit [darwin-x86_64]"}

@kares

kares commented Jul 3, 2020

Copy link
Copy Markdown
Contributor

yes, I know - there's more work on the warning front in terms of java-integration.
jruby-openssl still needs work (before release) - when it's released the warning you see won't be there ...

@jsvd
jsvd force-pushed the bump_jruby_9_2_12_0 branch from 4b49902 to a6b0751 Compare July 7, 2020 14:28
@elasticsearch-bot elasticsearch-bot self-assigned this Jul 7, 2020
yaauie
yaauie reviewed Jul 7, 2020
View reviewed changes
Comment thread docs/static/troubleshooting.asciidoc Outdated
@jsvd
jsvd force-pushed the bump_jruby_9_2_12_0 branch from 523f950 to 30eac95 Compare July 7, 2020 17:04
@jsvd
jsvd requested a review from yaauie July 7, 2020 17:05
kares
kares reviewed Jul 7, 2020
View reviewed changes
Comment thread docs/static/troubleshooting.asciidoc Outdated
karenzone
karenzone reviewed Jul 7, 2020
View reviewed changes

@karenzone karenzone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking time to update the troubleshooting docs, too! <3
Builds cleanly and LGTM.

yaauie
yaauie approved these changes Jul 7, 2020
View reviewed changes

@yaauie yaauie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@colinsurprenant

colinsurprenant commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

I just checked with recent JRuby and it seems that jruby-stdin-channel is not required anymore, JRuby $stdin is now interruptible. I will push a PR on the stdin input for this.

@yaauie

yaauie commented Jul 7, 2020

Copy link
Copy Markdown
Member

jenkins test this again please

@jsvd @yaauie
update jruby to 9.2.12.0
cf80f17 
Also tweak the documentation since most of the add-opens are no longer needed, except:

java.io due to colinsurprenant/jruby-stdin-channel#1
java.security due to jruby-openssl
java.nio.channels, sun.nio.ch, sun.management and java.io from jruby: https://github.com/jruby/jruby/blob/9.2.12.0/bin/.jruby.module_opts

Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
@jsvd
jsvd force-pushed the bump_jruby_9_2_12_0 branch from 30eac95 to cf80f17 Compare July 8, 2020 11:42
kares
kares approved these changes Jul 8, 2020
View reviewed changes

@kares kares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearch-bot
elasticsearch-bot merged commit 67eb274 into elastic:master Jul 8, 2020
@elasticsearch-bot

elasticsearch-bot commented Jul 8, 2020

Copy link
Copy Markdown

João Duarte merged this to master!

Pull request was also backported into the following branches:

Branch Commits
7.x 85a572a

@jsvd
jsvd deleted the bump_jruby_9_2_12_0 branch July 8, 2020 11:58
@jsvd

jsvd commented Jul 8, 2020

Copy link
Copy Markdown
Member Author

Thanks all for the feedback!

@colinsurprenant

colinsurprenant commented Jul 8, 2020

Copy link
Copy Markdown
Contributor

FYI I pushed logstash-plugins/logstash-input-stdin#19 to remove the usage of jruby-stdin-channel and get rid of the An illegal reflective access operation has occurred under Java 11.

@colinsurprenant colinsurprenant mentioned this pull request Jul 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaauie yaauie yaauie approved these changes
+2 more reviewers
@karenzone karenzone karenzone left review comments
@kares kares kares approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jsvd @kares @colinsurprenant @yaauie @elasticsearch-bot @karenzone