Skip to content

Doc: Provide accurate post-geoip lookup example#18092

Merged
karenzone merged 2 commits into
elastic:mainfrom
karenzone:2782-geoip-sample
Sep 3, 2025
Merged

Doc: Provide accurate post-geoip lookup example#18092
karenzone merged 2 commits into
elastic:mainfrom
karenzone:2782-geoip-sample

Conversation

@karenzone
Copy link
Copy Markdown
Contributor

@karenzone karenzone commented Sep 2, 2025

@karenzone karenzone self-assigned this Sep 2, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 2, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Sep 2, 2025

This pull request does not have a backport label. Could you fix it @karenzone? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 2, 2025 •
edited
Loading

🔍 Preview links for changed docs

@karenzone
Copy link
Copy Markdown
Contributor Author

karenzone commented Sep 2, 2025

@kaisecheng, a user pointed out that the "after" example is the same as the "before" example. Will you help me come up with a proper example, please?

@karenzone karenzone added backport-9.0 Automated backport to the 9.0 branch with mergify backport-9.1 Automated backport to the 9.1 branch labels Sep 2, 2025
@kaisecheng
Copy link
Copy Markdown
Contributor

kaisecheng commented Sep 3, 2025

@karenzone Thx. I updated the example and push to the branch.

karenzone
karenzone commented Sep 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renders as expected, and looks great!
Thank you, @kaisecheng.

@karenzone karenzone marked this pull request as ready for review September 3, 2025 13:22
@karenzone karenzone merged commit 23d06e6 into elastic:main Sep 3, 2025
11 checks passed
mergify Bot pushed a commit that referenced this pull request Sep 3, 2025
@karenzone @kaisecheng @mergify
Doc: Provide accurate post-geoip lookup example (#18092)
9113e98 
Co-authored-by: Kaise Cheng <kaise.cheng@elastic.co>
(cherry picked from commit 23d06e6)
mergify Bot pushed a commit that referenced this pull request Sep 3, 2025
@karenzone @kaisecheng @mergify
Doc: Provide accurate post-geoip lookup example (#18092)
6cba38e 
Co-authored-by: Kaise Cheng <kaise.cheng@elastic.co>
(cherry picked from commit 23d06e6)
This was referenced Sep 3, 2025
Merged
Merged
karenzone added a commit that referenced this pull request Sep 3, 2025
@mergify @karenzone @kaisecheng
Doc: Provide accurate post-geoip lookup example (#18092) (#18093)
f7e6016 
(cherry picked from commit 23d06e6)

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
Co-authored-by: Kaise Cheng <kaise.cheng@elastic.co>
karenzone added a commit that referenced this pull request Sep 3, 2025
@mergify @karenzone @kaisecheng
Doc: Provide accurate post-geoip lookup example (#18092) (#18094)
9ad2692 
(cherry picked from commit 23d06e6)

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
Co-authored-by: Kaise Cheng <kaise.cheng@elastic.co>
@karenzone karenzone deleted the 2782-geoip-sample branch September 3, 2025 15:01
@karenzone karenzone mentioned this pull request Sep 3, 2025
Merged
This was referenced Sep 3, 2025
Closed
Merged
@karenzone karenzone mentioned this pull request Sep 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@karenzone karenzone

Labels

backport-9.0 Automated backport to the 9.0 branch with mergify backport-9.1 Automated backport to the 9.1 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Website]: Same snap as part of before and after example in logstash lookup geoip filter

2 participants

@karenzone @kaisecheng