-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Backport smart exhaustive tests #18386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
donoghuc
merged 4 commits into
elastic:9.2
from
donoghuc:backport-smart-exhaustive-tests
Nov 1, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f41001a
feat(ci): support exhaustive tests for PRs (code changes or GH commen…
v1v 410d62c
bk: fix regex and add new file (#18382)
v1v 426fce4
bk(smart exhaustive tests): tune the steps to support GH comments and…
v1v 1555bd8
chore: remove test file for exhaustive tests and normalise github com…
v1v File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,66 @@ | ||
| { | ||
| "jobs": [ | ||
| { | ||
| "enabled": true, | ||
| "pipeline_slug": "logstash-pull-request-pipeline", | ||
| "allow_org_users": true, | ||
| "allowed_repo_permissions": ["admin", "write"], | ||
| "allowed_list": ["dependabot[bot]", "mergify[bot]", "github-actions[bot]", "elastic-vault-github-plugin-prod[bot]"], | ||
| "set_commit_status": true, | ||
| "build_on_commit": true, | ||
| "build_on_comment": true, | ||
| "trigger_comment_regex": "^(?:(?:buildkite\\W+)?(?:build|test)\\W+(?:this|it))", | ||
| "always_trigger_comment_regex": "^(?:(?:buildkite\\W+)?(?:build|test)\\W+(?:this|it))", | ||
| "skip_ci_labels": [ ], | ||
| "skip_target_branches": [ ], | ||
| "skip_ci_on_only_changed": [ | ||
| "^.github/", | ||
| "^docs/", | ||
| "^.mergify.yml$", | ||
| "^.pre-commit-config.yaml", | ||
| "\\.md$" | ||
| ], | ||
| "always_require_ci_on_changed": [ ] | ||
| } | ||
| ] | ||
| } | ||
| "jobs": [ | ||
| { | ||
| "enabled": true, | ||
| "pipeline_slug": "logstash-pull-request-pipeline", | ||
| "allow_org_users": true, | ||
| "allowed_repo_permissions": [ | ||
| "admin", | ||
| "write" | ||
| ], | ||
| "allowed_list": [ | ||
| "dependabot[bot]", | ||
| "mergify[bot]", | ||
| "github-actions[bot]", | ||
| "elastic-vault-github-plugin-prod[bot]" | ||
| ], | ||
| "set_commit_status": true, | ||
| "build_on_commit": true, | ||
| "build_on_comment": true, | ||
| "trigger_comment_regex": "^(?:(?:buildkite\\W+)?(?:build|test)\\W+(?:this|it))", | ||
| "always_trigger_comment_regex": "^(?:(?:buildkite\\W+)?(?:build|test)\\W+(?:this|it))", | ||
| "skip_ci_labels": [], | ||
| "skip_target_branches": [], | ||
| "skip_ci_on_only_changed": [ | ||
| "^.github/", | ||
| "^docs/", | ||
| "^.mergify.yml$", | ||
| "^.pre-commit-config.yaml", | ||
| "\\.md$" | ||
| ], | ||
| "always_require_ci_on_changed": [] | ||
| }, | ||
| { | ||
| "enabled": true, | ||
| "pipeline_slug": "logstash-smart-exhaustive-tests-pipeline", | ||
| "allow_org_users": true, | ||
| "allowed_repo_permissions": [ | ||
| "admin", | ||
| "write" | ||
| ], | ||
| "allowed_list": [ | ||
| "dependabot[bot]", | ||
| "mergify[bot]", | ||
| "github-actions[bot]" | ||
| ], | ||
| "set_commit_status": true, | ||
| "build_on_commit": true, | ||
| "build_on_comment": true, | ||
| "trigger_comment_regex": "^run\\s+exhaustive\\s+tests$", | ||
| "always_trigger_comment_regex": "^run\\s+exhaustive\\s+tests$", | ||
| "skip_ci_labels": [], | ||
| "skip_target_branches": [], | ||
| "skip_ci_on_only_changed": [ | ||
| "^.github/", | ||
| "^docs/", | ||
| "^.mergify.yml$", | ||
| "^.pre-commit-config.yaml", | ||
| "\\.md$" | ||
| ], | ||
| "always_require_ci_on_changed": [ | ||
| "^qa/acceptance/", | ||
| "^ci/acceptance_tests.sh" | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| steps: | ||
| - label: "Trigger logstash-exhaustive-tests-pipeline for PRs with qa/acceptance/ changes" | ||
| if: build.pull_request.id != null && build.env("GITHUB_PR_TRIGGER_COMMENT") != "run exhaustive tests" | ||
| plugins: | ||
| - monorepo-diff#v1.0.1: | ||
| diff: "git diff --name-only origin/${GITHUB_PR_TARGET_BRANCH}...HEAD" | ||
| interpolation: false | ||
| watch: | ||
| - path: | ||
| - ^qa/acceptance/ | ||
| - ^ci/acceptance_tests.sh | ||
| - .buildkite/smart_exhaustive_tests_pipeline.yml | ||
| config: | ||
| trigger: "logstash-exhaustive-tests-pipeline" | ||
| build: | ||
| commit: "${BUILDKITE_COMMIT}" | ||
| branch: "${BUILDKITE_BRANCH}" | ||
| env: | ||
| BUILDKITE_PULL_REQUEST: "${BUILDKITE_PULL_REQUEST}" | ||
| BUILDKITE_PULL_REQUEST_BASE_BRANCH: "${BUILDKITE_PULL_REQUEST_BASE_BRANCH}" | ||
| ELASTIC_SLACK_NOTIFICATIONS_ENABLED: false | ||
|
|
||
| - label: "Trigger logstash-exhaustive-tests-pipeline for GitHub comments" | ||
| if: build.env("GITHUB_PR_TRIGGER_COMMENT") == "run exhaustive tests" | ||
| trigger: "logstash-exhaustive-tests-pipeline" | ||
| build: | ||
| commit: "HEAD" | ||
| branch: "pull/${BUILDKITE_PULL_REQUEST}/merge" | ||
| env: | ||
| BUILDKITE_PULL_REQUEST: "${BUILDKITE_PULL_REQUEST}" | ||
| ELASTIC_SLACK_NOTIFICATIONS_ENABLED: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need to keep catalog-info in the branch (main is the source of truth as my understanding) but if it doesn't confuse, it is okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i was thinking though that a clean commit without selecting certain files would be good. Going to let @v1v have a chance to chime in before merging. Thanks for the review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine here